CNTRLPLANE-3984: document all skills and commands in SKILLS.md - #9210
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughExpanded Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
area/ai
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.claude/SKILLS.md (1)
135-135: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd language identifiers to all fenced code blocks.
markdownlint-cli2reports MD040 for these fences. Use an identifier such astextorconsole.Proposed fix
-``` +```textAlso applies to: 264-264, 304-304, 323-323, 344-344, 361-361, 376-376
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/SKILLS.md at line 135, Update every fenced code block in SKILLS.md, including the referenced locations, to specify a language identifier after the opening fence; use text or console where the block is not language-specific, while preserving each block’s contents.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/SKILLS.md:
- Around line 263-266: Update the usage strings in SKILLS.md for /konflux-build
and /test-tag-pipeline so both component-name and branch-name are visibly
optional, matching the contracts in the corresponding command definitions;
preserve the existing argument names and --non-expiring option.
---
Nitpick comments:
In @.claude/SKILLS.md:
- Line 135: Update every fenced code block in SKILLS.md, including the
referenced locations, to specify a language identifier after the opening fence;
use text or console where the block is not language-specific, while preserving
each block’s contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ffe9e3de-e093-4cd7-9681-12f8dad7c07f
📒 Files selected for processing (1)
.claude/SKILLS.md
celebdor
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@celebdor: This pull request references CNTRLPLANE-3984 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9210 +/- ##
==========================================
+ Coverage 44.81% 44.96% +0.14%
==========================================
Files 775 778 +3
Lines 97219 97444 +225
==========================================
+ Hits 43572 43819 +247
+ Misses 50644 50602 -42
- Partials 3003 3023 +20 see 34 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add missing entries for 4 skills (create-cpo-override, validate-pr-override-images, triage-leaked-infra, dev/*) and 6 commands (konflux-build, test-tag-pipeline, pr-report, e2e-analyze, ocpstrat-review, dual-stream-stories). Signed-off-by: Antoni Segura Puimedon <asegurap@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ddb5fb6 to
c64d451
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/SKILLS.md:
- Around line 151-153: Add an explicit language identifier, using text or
console, to the opening fences for the usage examples around
/validate-pr-override-images and all listed additional sections in SKILLS.md.
Preserve the existing example contents and formatting.
- Line 17: Update the automatic-activation entries in SKILLS.md to match the
activation conditions declared by the corresponding SKILL.md metadata: remove
Discussing commit practices, Debugging Go-specific issues, and Discussing Go
best practices unless their metadata is updated to explicitly support those
triggers.
- Around line 114-217: Update the command documentation in .claude/SKILLS.md by
removing entries for the nonexistent ocpstrat-review.md and
dual-stream-stories.md commands, and adding documentation for the existing
fix-hypershift-repo-robot-pr.md, restructure-commits.md, and
workflows/feature-development.md commands. Keep the documented command paths and
descriptions aligned with the repository files.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d9efff1b-4105-4a0f-9cce-8900311af1cf
📒 Files selected for processing (1)
.claude/SKILLS.md
|
|
||
| - Generating commit messages | ||
| - Creating commits | ||
| - Discussing commit practices |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Align automatic-activation entries with the skill contracts.
The supplied skill metadata does not list Discussing commit practices, Debugging Go-specific issues, or Discussing Go best practices as activation conditions. Remove these entries or update the corresponding SKILL.md metadata to support them.
Also applies to: 45-46
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/SKILLS.md at line 17, Update the automatic-activation entries in
SKILLS.md to match the activation conditions declared by the corresponding
SKILL.md metadata: remove Discussing commit practices, Debugging Go-specific
issues, and Discussing Go best practices unless their metadata is updated to
explicitly support those triggers.
|
|
||
| - Systematic approach to debugging cluster issues | ||
| - Reduces time spent investigating stuck resources | ||
| - Provides ready-to-use kubectl commands | ||
| - Covers common scenarios and resolutions | ||
|
|
||
| ### Create CPO Override | ||
|
|
||
| **Location:** `.claude/skills/create-cpo-override/` | ||
|
|
||
| **Description:** Interactively creates control-plane-operator image override entries in `overrides.yaml`. Automates image discovery, fix verification, YAML editing, and PR preparation. | ||
|
|
||
| **Auto-applies when:** | ||
|
|
||
| - Creating or updating CPO image overrides | ||
| - Preparing hotfix override PRs | ||
|
|
||
| **Covers:** | ||
|
|
||
| - Image resolution via `skopeo` and `oc adm release info` | ||
| - Fix verification against PR commits | ||
| - YAML editing of `hypershift-operator/controlplaneoperator-overrides/assets/overrides.yaml` | ||
| - PR preparation compatible with `/validate-pr-override-images` | ||
|
|
||
| **Requirements:** | ||
|
|
||
| - `skopeo`, `oc`, `gh` CLI installed and authenticated | ||
| - Release branches fetched locally | ||
|
|
||
| ### Validate PR Override Images | ||
|
|
||
| **Location:** `.claude/skills/validate-pr-override-images/` | ||
|
|
||
| **Description:** Validates that CPO override images in a PR actually contain the PRs they claim to include. | ||
|
|
||
| **Usage:** | ||
|
|
||
| ``` | ||
| /validate-pr-override-images <PR-URL-or-number> | ||
| ``` | ||
|
|
||
| **Auto-applies when:** | ||
|
|
||
| - Reviewing CPO override PRs | ||
| - Verifying hotfix image contents | ||
|
|
||
| **Covers:** | ||
|
|
||
| - Parsing the PR description's structured validation contract (`branch: X wants: PR1, PR2`) | ||
| - Inspecting images via `skopeo` to verify claimed fixes are present | ||
| - Cross-referencing commits against release branches | ||
|
|
||
| ### Triage Leaked Infrastructure | ||
|
|
||
| **Location:** `.claude/skills/triage-leaked-infra/` | ||
|
|
||
| **Description:** Assesses whether AWS VPCs or infrastructure sets from HyperShift CI are safe to delete. Every claim is backed by empirical AWS queries. | ||
|
|
||
| **Auto-applies when:** | ||
|
|
||
| - User pastes `cleanleaked` output and asks if resources are safe to delete | ||
| - Investigating orphaned AWS VPCs or infra sets | ||
| - Triaging LEAKED or UNCERTAIN verdicts | ||
|
|
||
| **Covers:** | ||
|
|
||
| - Protection tag checks (`do-not-delete`, `ci-cluster`) | ||
| - VPC-to-infraID derivation and reverse lookup | ||
| - Running instance and resource checks | ||
| - Safety verdicts (PASS/FAIL/UNKNOWN) per check | ||
|
|
||
| **Requirements:** | ||
|
|
||
| - AWS CLI configured for the HyperShift CI account (`us-east-1`) | ||
|
|
||
| ### Development Workflows | ||
|
|
||
| **Location:** `.claude/skills/dev/` | ||
|
|
||
| **Description:** A collection of development workflow skills for building, deploying, and testing HyperShift locally. | ||
|
|
||
| **Sub-skills:** | ||
|
|
||
| | Skill | Description | | ||
| |-------|-------------| | ||
| | `build-cpo-image` | Build and push a control-plane-operator container image for live cluster testing | | ||
| | `build-ho-image` | Build and push a hypershift-operator container image for live cluster testing | | ||
| | `create-hc-aws` | Create a HostedCluster on AWS for development/testing, with optional custom CPO/HO images | | ||
| | `destroy-hc-aws` | Destroy a HostedCluster and all associated AWS infrastructure (VPC, IAM, Route53, etc.) | | ||
| | `e2e-run-aws` | Run and iterate on HyperShift e2e tests against a live cluster | | ||
| | `git-env` | Create development environments with git worktrees, branches, commits, and push to remote | | ||
| | `install-ho-aws` | Install HyperShift Operator with private AWS and external-dns settings | | ||
|
|
||
| **Auto-applies when:** | ||
|
|
||
| - Building container images for testing | ||
| - Creating or destroying hosted clusters for development | ||
| - Running e2e tests locally | ||
| - Setting up git worktrees for development | ||
|
|
||
| ## How Skills Work | ||
|
|
||
| Skills are automatically invoked by Claude based on context. You don't need to do anything special - just ask Claude to: | ||
|
|
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
doc=".claude/SKILLS.md"
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
sed -n 's/^\*\*Location:\*\* `\([^`]*\)`/\1/p' "$doc" | sort -u > "$tmp/documented"
grep '^\.claude/skills/' "$tmp/documented" | sed 's#/$##' | sort -u > "$tmp/documented_skills" || true
grep '^\.claude/commands/' "$tmp/documented" | sort -u > "$tmp/documented_commands" || true
fd --type f --glob 'SKILL.md' .claude/skills \
| sed 's#^\./##; s#/SKILL.md$##' | sort -u > "$tmp/actual_skills"
fd --type f --extension md .claude/commands \
| sed 's#^\./##' | sort -u > "$tmp/actual_commands"
echo "Missing skill locations:"
comm -23 "$tmp/documented_skills" "$tmp/actual_skills"
echo "Undocumented skill locations:"
comm -13 "$tmp/documented_skills" "$tmp/actual_skills"
echo "Missing command locations:"
comm -23 "$tmp/documented_commands" "$tmp/actual_commands"
echo "Undocumented command locations:"
comm -13 "$tmp/documented_commands" "$tmp/actual_commands"Repository: openshift/hypershift
Length of output: 528
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
doc=".claude/SKILLS.md"
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
# Extract all documented locations from SKILLS.md
sed -n 's/^\*\*Location:\*\* `\([^`]*\)`/\1/p' "$doc" | sort -u > "$tmp/documented_all"
# Separate into skills and commands
grep '^\.claude/skills/' "$tmp/documented_all" | sed 's#/$##' | sort -u > "$tmp/documented_skills" || true
grep '^\.claude/commands/' "$tmp/documented_all" | sort -u > "$tmp/documented_commands" || true
# Find actual SKILL.md files
fd --type f 'SKILL\.md$' .claude/skills/ 2>/dev/null \
| sed 's#^\./##; s#/SKILL\.md$##' | sort -u > "$tmp/actual_skills" || true
# Find actual command files (any .md files in .claude/commands)
fd --type f --full-path '.claude/commands/*.md' 2>/dev/null \
| sed 's#^\./##' | sort -u > "$tmp/actual_commands" || true
echo "=== Documented Locations (all) ==="
cat "$tmp/documented_all"
echo ""
echo "=== Documented Skills ==="
cat "$tmp/documented_skills"
echo ""
echo "=== Actual Skills (with SKILL.md) ==="
cat "$tmp/actual_skills"
echo ""
echo "=== Documented Commands ==="
cat "$tmp/documented_commands"
echo ""
echo "=== Actual Commands ==="
cat "$tmp/actual_commands"
echo ""
echo "=== DISCREPANCIES ==="
echo "Missing skill locations (documented but not found):"
comm -23 "$tmp/documented_skills" "$tmp/actual_skills" || echo " (none)"
echo ""
echo "Undocumented skill locations (found but not documented):"
comm -13 "$tmp/documented_skills" "$tmp/actual_skills" || echo " (none)"
echo ""
echo "Missing command locations (documented but not found):"
comm -23 "$tmp/documented_commands" "$tmp/actual_commands" || echo " (none)"
echo ""
echo "Undocumented command locations (found but not documented):"
comm -13 "$tmp/documented_commands" "$tmp/actual_commands" || echo " (none)"Repository: openshift/hypershift
Length of output: 2822
🏁 Script executed:
# Verify the actual directories exist and check for missing command files
echo "=== Checking .claude/commands/ directory ==="
if [ -d ".claude/commands" ]; then
echo "Directory exists. Contents:"
find .claude/commands -type f 2>/dev/null | head -20 || echo " (no files found)"
else
echo "Directory does not exist"
fi
echo ""
echo "=== Checking .claude/skills/ directory ==="
if [ -d ".claude/skills" ]; then
echo "Directory exists. Structure:"
find .claude/skills -name "SKILL.md" | sort
else
echo "Directory does not exist"
fi
echo ""
echo "=== Full .claude/skills/ tree (10 levels) ==="
tree -L 3 .claude/skills/ 2>/dev/null || find .claude/skills -type f | head -30Repository: openshift/hypershift
Length of output: 1980
🏁 Script executed:
# Extract exact locations documented in SKILLS.md lines 114-217 and 275-442
echo "=== Lines 114-217 from SKILLS.md ==="
sed -n '114,217p' .claude/SKILLS.md | grep -E '^\*\*Location:\*\*' || echo "(no Location entries)"
echo ""
echo "=== Lines 275-442 from SKILLS.md ==="
sed -n '275,442p' .claude/SKILLS.md | grep -E '^\*\*Location:\*\*' || echo "(no Location entries)"Repository: openshift/hypershift
Length of output: 796
🏁 Script executed:
# Verify which documented command files actually exist
commands_doc=(
".claude/commands/konflux-build.md"
".claude/commands/update-konflux-tasks.md"
".claude/commands/test-tag-pipeline.md"
".claude/commands/pr-report.md"
".claude/commands/e2e-analyze.md"
".claude/commands/ocpstrat-review.md"
".claude/commands/dual-stream-stories.md"
)
echo "=== Command File Verification ==="
for cmd in "${commands_doc[@]}"; do
if [ -f "$cmd" ]; then
echo "✓ EXISTS: $cmd"
else
echo "✗ MISSING: $cmd"
fi
done
echo ""
echo "=== Actual .claude/commands/ files ==="
find .claude/commands -type f -name "*.md" | sortRepository: openshift/hypershift
Length of output: 869
Two documented command files do not exist; two additional command files are undocumented.
In lines 275-442 of .claude/SKILLS.md:
.claude/commands/ocpstrat-review.mdis documented but does not exist..claude/commands/dual-stream-stories.mdis documented but does not exist.
Additionally, three command files exist in the repository but are not documented in the specified lines:
.claude/commands/fix-hypershift-repo-robot-pr.md.claude/commands/restructure-commits.md.claude/commands/workflows/feature-development.md
All four skill locations in lines 114-217 exist and match their documented paths.
, ,
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 151-151: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/SKILLS.md around lines 114 - 217, Update the command documentation
in .claude/SKILLS.md by removing entries for the nonexistent ocpstrat-review.md
and dual-stream-stories.md commands, and adding documentation for the existing
fix-hypershift-repo-robot-pr.md, restructure-commits.md, and
workflows/feature-development.md commands. Keep the documented command paths and
descriptions aligned with the repository files.
| ``` | ||
| /validate-pr-override-images <PR-URL-or-number> | ||
| ``` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add language identifiers to the remaining usage fences.
markdownlint-cli2 reports MD040 for these fences. Use text or console after each opening fence.
Also applies to: 235-237, 295-297, 328-330, 340-342, 362-364, 386-388, 405-407, 422-424
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 151-151: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/SKILLS.md around lines 151 - 153, Add an explicit language
identifier, using text or console, to the opening fences for the usage examples
around /validate-pr-override-images and all listed additional sections in
SKILLS.md. Preserve the existing example contents and formatting.
Source: Linters/SAST tools
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@cblecker: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@celebdor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Summary
create-cpo-override,validate-pr-override-images,triage-leaked-infra,dev/*with 7 sub-skills) and 6 commands (konflux-build,test-tag-pipeline,pr-report,e2e-analyze,ocpstrat-review,dual-stream-stories) to.claude/SKILLS.md.claude/skills/and.claude/commands/are now documented in the summary fileTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit