CNTRLPLANE-3997: correct wrangler pages deploy flags for docs publish

[celebdor]

Summary

Fixes the failing "Deploy Production" job in the new docs production publishing workflow.

• wrangler pages deploy (v4) has no --production flag — it never existed in any wrangler version. It only classifies a deployment as production by comparing --branch against the Cloudflare project's configured production branch (isProduction = project.production_branch === branch, confirmed by inspecting the bundled wrangler CLI). Passing --production made the command fail with Unknown argument: production, exit code 1. Replaced it with --branch=main, matching the project's configured production branch, consistent with how the preview job already passes --branch.
• The ARC runners have no $HOME set, so Wrangler was failing with EACCES: permission denied, mkdir '/.config' trying to write its debug log (non-fatal here, but noisy and worth fixing). Set HOME to ${{ runner.temp }} for the wrangler-action steps in both the reusable deploy workflow and the PR-preview deploy workflow.

Ref: CNTRLPLANE-3997

Test plan

• Merge and confirm Docs Publish / Deploy Production succeeds and https://hypershift.pages.dev/ updates
• Open a docs PR and confirm the preview deploy still works and produces https://pr-<number>.hypershift.pages.dev

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved documentation deployment reliability across production and preview environments.
  • Updated production deployments to use the main branch configuration.
  • Ensured deployment processes use a temporary runner directory for consistent execution.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

📝 Walkthrough

Walkthrough

The documentation deployment workflows now set HOME to ${{ runner.temp }} for Cloudflare Pages deployment steps. The reusable workflow applies this setting to production and preview deployments. Production deployment now targets the main branch instead of using the --production option.

Possibly related PRs

• openshift/hypershift#9221: Introduced the reusable Cloudflare Docs deployment workflow modified here.

Suggested reviewers: bryan-cox

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only two GitHub Actions YAML workflows; no Ginkgo declarations or test-like files are changed, so this check is not applicable.
Test Structure And Quality	✅ Passed	The pull request changes only two GitHub Actions workflow files; it adds or modifies no Ginkgo tests, so the listed test-quality requirements are not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only GitHub Actions workflow steps for Cloudflare Pages; it adds no deployment manifests, operator code, controllers, replicas, affinity, selectors, tolerations, or topology constrai...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only two GitHub Actions YAML workflows; it adds no Ginkgo e2e tests or test code, so this compatibility check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds HOME settings and changes Wrangler to --branch=main; added lines contain no weak algorithms, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	The commit changes only GitHub Actions workflows, adding HOME and --branch=main; no privileged, hostPID/Network/IPC, SYS_ADMIN, or escalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only adds HOME overrides and changes the Wrangler branch argument; it adds no logging of secrets, tokens, PII, hostnames, or customer data.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the Wrangler Pages deployment flag fix, which is the primary change in the pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@celebdor: This pull request references CNTRLPLANE-3997 which is a valid jira issue.

Details

In response to this:

Summary

Fixes the failing "Deploy Production" job in the new docs production publishing workflow.

• wrangler pages deploy (v4) has no --production flag — it never existed in any wrangler version. It only classifies a deployment as production by comparing --branch against the Cloudflare project's configured production branch (isProduction = project.production_branch === branch, confirmed by inspecting the bundled wrangler CLI). Passing --production made the command fail with Unknown argument: production, exit code 1. Replaced it with --branch=main, matching the project's configured production branch, consistent with how the preview job already passes --branch.
• The ARC runners have no $HOME set, so Wrangler was failing with EACCES: permission denied, mkdir '/.config' trying to write its debug log (non-fatal here, but noisy and worth fixing). Set HOME to ${{ runner.temp }} for the wrangler-action steps in both the reusable deploy workflow and the PR-preview deploy workflow.

Ref: CNTRLPLANE-3997

Test plan

• Merge and confirm Docs Publish / Deploy Production succeeds and https://hypershift.pages.dev/ updates
• Open a docs PR and confirm the preview deploy still works and produces https://pr-<number>.hypershift.pages.dev

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
• Improved documentation deployment reliability across production and preview environments.
• Updated production deployments to use the main branch configuration.
• Ensured deployment processes use a temporary runner directory for consistent execution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.