[release-4.22] OCPBUGS-119976: fix(cpo): include unavailable components in KASLoadBalancerNotReachable message - #9502
Conversation
…le message When a KAS health check error occurs simultaneously with unavailable components, the component information was silently dropped due to switch-case priority. Append the component unavailability message to the health check error so operators see the full picture. Additionally, query controlPlaneComponentsAvailable when healthCheckErr is non-nil even if the HCP was previously Available. The alreadyAvailable short-circuit skipped this call, so for a previously-Available HCP the component names were never populated in the error message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-119976, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.22 #9502 +/- ##
=============================================
Coverage 36.71% 36.72%
=============================================
Files 777 777
Lines 95484 95487 +3
=============================================
+ Hits 35061 35064 +3
Misses 57580 57580
Partials 2843 2843
🚀 New features to boost your workflow:
|
This is a manual cherry-pick of #9232 to
release-4.22.The cherry-pick bot failed to create this backport automatically. Conflicts were resolved while preserving the intent of the fix.
Changes
controlPlaneComponentsAvailableis queried whenhealthCheckErr != nil(not only when the HCP was not previously available)KASLoadBalancerNotReachableconditionsFixes https://redhat.atlassian.net/browse/OCPBUGS-119976
AI-generated. Review for accuracy.
@georgelipceanu requested in Slack thread