OCPBUGS-120685: fix(e2e): label flaking nodepool osImageStream test informing

[ironcladlou]

This test was recently introduced and is now flaking, it probably should be been marked informing until it was proven stable. This commit marks the test as informing for now.

Summary by CodeRabbit

• Tests
  • Updated the node pool OS image stream verification test to be informational rather than blocking.
  • Test logic and assertions remain unchanged.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@ironcladlou: This pull request references Jira Issue OCPBUGS-120685, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This test was recently introduced and is now flaking, it probably should be been marked informing until it was proven stable. This commit marks the test as informing for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: b90edecc-4de6-40ee-874d-b5d68f1cdd51

📥 Commits

Reviewing files that changed from the base of the PR and between 1a86b5d and 498dceb.

📒 Files selected for processing (1)

• test/e2e/v2/tests/nodepool_osimagestream_test.go

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The node pool OS image stream verification test now carries the Informing label. The test body, assertions, and control flow remain unchanged.

Suggested reviewers: jparrill, sdminonne, bennerv

Merge Risk: ⚪ Minimal · up to 498dc

The OS image stream verification test is now informational while retaining its existing behavior. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: marking the flaking nodepool osImageStream end-to-end test as informing.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only the Informing label on an existing It test. The test title is unchanged from the parent revision and uses static text. All Describe and It titles in the cha…
Test Structure And Quality	✅ Passed	PASS: The pull-request diff changes only the Ginkgo declaration by adding Label("Informing"). It does not change test behavior, assertions, setup, cleanup, cluster operations, or wait calls. The aff…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request changes only test/e2e/v2/tests/nodepool_osimagestream_test.go. The diff adds the Informing label to an existing test and does not modify deployment manifests, operators, co…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only the existing Ginkgo test declaration by adding Label("Informing"). The exact diff shows no new test, networking code, IP handling, URL construction, image pull, o…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes one line in test/e2e/v2/tests/nodepool_osimagestream_test.go: it adds the Ginkgo Label("Informing") to an existing test. The parent diff shows no cryptographic algor…
Container-Privileges	✅ Passed	PASS: The pull request changes only the Ginkgo test declaration by adding Label("Informing"). The parent-to-HEAD diff contains no privilege, host namespace, capability, security context, or root-use…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only the test declaration by adding the Informing label. The diff adds no logging calls and no sensitive data. Existing GinkgoWriter messages were not changed by thi…

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only the Informing label on an existing It test. The test title is unchanged from the parent revision and uses static text. All Describe and It titles in the changed file use literals, with no generated names, timestamps, UUIDs, node names, namespaces, IP addresses, or other per-run values.

Full details: Test Structure And Quality

Explanation

PASS: The pull-request diff changes only the Ginkgo declaration by adding Label("Informing"). It does not change test behavior, assertions, setup, cleanup, cluster operations, or wait calls. The affected test already uses DeferCleanup for the created NodePool and explicit timeouts for EventuallyObject calls. No stated test-structure or quality failure is introduced by this change.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only test/e2e/v2/tests/nodepool_osimagestream_test.go. The diff adds the Informing label to an existing test and does not modify deployment manifests, operators, controllers, or scheduling constraints. Existing test logic, including its replica setting, is unchanged and is not introduced by this pull request.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only the existing Ginkgo test declaration by adding Label("Informing"). The exact diff shows no new test, networking code, IP handling, URL construction, image pull, or external service access. The test body and its cluster NodePool/Node API operations are unchanged. Therefore, this pull request introduces no IPv4 assumption or external connectivity requirement covered by the check.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes one line in test/e2e/v2/tests/nodepool_osimagestream_test.go: it adds the Ginkgo Label("Informing") to an existing test. The parent diff shows no cryptographic algorithm, crypto implementation, or secret/token comparison change. The weak-crypto conditions are not applicable.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only the Ginkgo test declaration by adding Label("Informing"). The parent-to-HEAD diff contains no privilege, host namespace, capability, security context, or root-user setting. Repository evidence shows Informing is a test-failure handling label, not a container or Kubernetes privilege setting.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only the test declaration by adding the Informing label. The diff adds no logging calls and no sensitive data. Existing GinkgoWriter messages were not changed by this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: build linters: unable to load custom analyzer "hypershiftlinter": hack/tools/bin/hypershiftlinter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "hypershiftlinter": hack/tools/bin/hypershiftlinter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@ironcladlou: This pull request references Jira Issue OCPBUGS-120685, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

This test was recently introduced and is now flaking, it probably should be been marked informing until it was proven stable. This commit marks the test as informing for now.

Summary by CodeRabbit

• Tests
• Updated the node pool OS image stream verification test to be informational rather than blocking.
• Test logic and assertions remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/e2e/OWNERS [ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.05%. Comparing base (1a86b5d) to head (498dceb).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9505   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         786      786           
  Lines       99169    99169           
=======================================
  Hits        46664    46664           
  Misses      49349    49349           
  Partials     3156     3156           

Flag	Coverage Δ
cmd-support	40.65% <ø> (ø)
cpo-hostedcontrolplane	50.32% <ø> (ø)
cpo-other	47.60% <ø> (ø)
hypershift-operator	57.24% <ø> (ø)
other	34.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jparrill]

/lgtm

[jparrill]

/verified by E2E Passing.

No deeper verification needed.

[jparrill]

/retest-required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-5-0
/test e2e-aws-5-0
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-azure-self-managed
/test e2e-v2-gke

[openshift-ci-robot]

@jparrill: This PR has been marked as verified by E2E Passing..

Details

In response to this:

/verified by E2E Passing.

No deeper verification needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD c81e6d2 and 2 for PR HEAD 498dceb in total

[cwbotbot]

Test Results

e2e-aks

• Status: ✅ PASS
• Started: 2026-09-04T07:57:28Z
• View Job
• View Job History

[ironcladlou]

/retest

[openshift-ci]

@ironcladlou: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ironcladlou: Jira Issue OCPBUGS-120685: Some pull requests linked via external trackers have merged:

• openshift/hypershift#9505

The following pull request, linked via external tracker, has not merged:

• openshift/hypershift#9506 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-120685 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

This test was recently introduced and is now flaking, it probably should be been marked informing until it was proven stable. This commit marks the test as informing for now.

Summary by CodeRabbit

• Tests
• Updated the node pool OS image stream verification test to be informational rather than blocking.
• Test logic and assertions remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.