[release-4.22] OCPBUGS-98153: update HyperShift deployment manifest#1315
Conversation
Add missing RELATED_IMAGE environment variables to the HyperShift deployment manifest to provide correct images for the runtime extractor DaemonSet. Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-93805 has been cloned as Jira Issue OCPBUGS-98153. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @TwoDCube |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98153, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @TwoDCube |
|
@TwoDCube: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
Claude does not think retesting will work, I will stop trying, I think @opokornyy you might need to take a look Claude outputNow the picture is decisive. Here's the newest failure. Newest run (07-16 01:58): serial failed on 2 pre-existing test bugs — retest won't clear it This time the serial job got a healthy cluster and ran the full suite (no infra flake), so the two real failures surfaced. Both fail on other PRs and both branches — neither is caused by this cherry-pick: = 2 failed, 37 passed, 4 skipped, 212 deselected in 1:40:36 =
What changed in my read The serial job on release-4.22 is effectively deterministically red right now — PRs 1317 and 1318 (unrelated to this cherry-pick) fail with the exact same two tests on every run. Unlike e2e (which I correctly called as a flake — it's now passing consistently), /retest will not fix serial: it keeps landing on these same two failures, or occasionally an unrelated infra flake like last run's node-readiness timeout. ┌─────────────┬──────────────────────┬───────────────────────────────────────────┐ Recommendation Stop retesting the serial job — it can't go green on its own. The two blockers are pre-existing suite issues, provably not from this manifest-only change (still inert on the GCP self-managed profile), and e2e is now reliably green. The realistic paths:
|
We need to get this PR - #1317 merged first then it should pass. I will run it when it is ready. |
|
/retest |
|
/label backport-risk-assessed |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, opokornyy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
a600775
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-98153 Jira Issue OCPBUGS-98153 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #1313
/assign opokornyy