Skip to content

[release-4.22] OCPBUGS-98153: update HyperShift deployment manifest#1315

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1313-to-release-4.22
Jul 17, 2026
Merged

[release-4.22] OCPBUGS-98153: update HyperShift deployment manifest#1315
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1313-to-release-4.22

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #1313

/assign opokornyy

Add missing RELATED_IMAGE environment variables
to the HyperShift deployment manifest to provide
correct images for the runtime extractor
DaemonSet.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9f8aabf8-bae1-4fce-a7ae-8df346494e2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ncaak and opokornyy July 9, 2026 08:59
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-93805 has been cloned as Jira Issue OCPBUGS-98153. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-98153: update HyperShift deployment manifest

Details

In response to this:

This is an automated cherry-pick of #1313

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-93805: update HyperShift deployment manifest [release-4.22] OCPBUGS-98153: update HyperShift deployment manifest Jul 9, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 9, 2026
@opokornyy

Copy link
Copy Markdown
Contributor

/cc @TwoDCube

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98153, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-93805 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-93805 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1313

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from TwoDCube July 9, 2026 09:00
@TwoDCube

Copy link
Copy Markdown
Member

/verified by @TwoDCube

@Cluster Bot > build 4.22,openshift/insights-operator#1315

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2075440144751529984

% oc adm release extract registry.build06.ci.openshift.org/ci-ln-8y8sfxk/release:latest --to=1315
% cat 1315/0000_50_insights-operator_06-deployment-ibm-cloud-managed.yaml | yq '.spec.template.spec.containers[0].env'
- name: POD_NAME
  valueFrom:
    fieldRef:
      fieldPath: metadata.name
- name: POD_NAMESPACE
  valueFrom:
    fieldRef:
      fieldPath: metadata.namespace
- name: RELEASE_VERSION
  value: 4.22.0-0-2026-07-10-044716-test-ci-ln-8y8sfxk-latest
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXTRACTOR
  value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:b8907fa7440332688b68f77dcabb57d07cc685b3570f16c8383805a4333760ea
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXPORTER
  value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:0b1d40fcdd5592d85289c7a185f9dac2348cbf7add3d1bb7ce3a8c8204172c1d
- name: RELATED_IMAGE_KUBE_RBAC_PROXY
  value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:ac7014fd0ba615e0d46cdc119a5e6fc83baf7277e69cccf150e546659045b251

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@TwoDCube: This PR has been marked as verified by @TwoDCube.

Details

In response to this:

/verified by @TwoDCube

@Cluster Bot > build 4.22,openshift/insights-operator#1315

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2075440144751529984

% oc adm release extract registry.build06.ci.openshift.org/ci-ln-8y8sfxk/release:latest --to=1315
% cat 1315/0000_50_insights-operator_06-deployment-ibm-cloud-managed.yaml | yq '.spec.template.spec.containers[0].env'
- name: POD_NAME
 valueFrom:
   fieldRef:
     fieldPath: metadata.name
- name: POD_NAMESPACE
 valueFrom:
   fieldRef:
     fieldPath: metadata.namespace
- name: RELEASE_VERSION
 value: 4.22.0-0-2026-07-10-044716-test-ci-ln-8y8sfxk-latest
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXTRACTOR
 value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:b8907fa7440332688b68f77dcabb57d07cc685b3570f16c8383805a4333760ea
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXPORTER
 value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:0b1d40fcdd5592d85289c7a185f9dac2348cbf7add3d1bb7ce3a8c8204172c1d
- name: RELATED_IMAGE_KUBE_RBAC_PROXY
 value: registry.build06.ci.openshift.org/ci-ln-8y8sfxk/stable@sha256:ac7014fd0ba615e0d46cdc119a5e6fc83baf7277e69cccf150e546659045b251

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TwoDCube

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@TwoDCube

Copy link
Copy Markdown
Member

/retest

3 similar comments
@opokornyy

Copy link
Copy Markdown
Contributor

/retest

@TwoDCube

Copy link
Copy Markdown
Member

/retest

@TwoDCube

Copy link
Copy Markdown
Member

/retest

@TwoDCube

Copy link
Copy Markdown
Member

Claude does not think retesting will work, I will stop trying, I think @opokornyy you might need to take a look

Claude output

Now the picture is decisive. Here's the newest failure.

Newest run (07-16 01:58): serial failed on 2 pre-existing test bugs — retest won't clear it

This time the serial job got a healthy cluster and ran the full suite (no infra flake), so the two real failures surfaced. Both fail on other PRs and both branches — neither is caused by this cherry-pick:

= 2 failed, 37 passed, 4 skipped, 212 deselected in 1:40:36 =

  1. test_communication::test_block_one_communication[set_network_policy0] — a stale test assertion (Post vs Get)
    expected pattern: Post "https://10.129.2.7:8443/gather_runtime_info": context deadline exceeded
    actual value: Get "https://10.129.2.7:8443/gather_runtime_info": context deadline exceeded
    The test hardcodes an expected error string with the HTTP verb Post, but the runtime-extractor exporter now issues a Get to that endpoint, so the regex never matches. This is a test-suite bug — the expected string is out of date with current exporter behavior. It fails on master (PR 1316 ×3) and on release-4.22 PRs 1317 and 1318 as well.

  2. test_namespaces::test_overlapping_uids — a release-4.22-specific timeout
    wait_for.TimedOutError. Note the branch pattern: it fails on every release-4.22 serial run (1315, 1317, 1318 — count=2 each) and never on master (count=0 everywhere). So it's a branch-specific problem on release-4.22, hitting all PRs regardless of content.

What changed in my read

The serial job on release-4.22 is effectively deterministically red right now — PRs 1317 and 1318 (unrelated to this cherry-pick) fail with the exact same two tests on every run. Unlike e2e (which I correctly called as a flake — it's now passing consistently), /retest will not fix serial: it keeps landing on these same two failures, or occasionally an unrelated infra flake like last run's node-readiness timeout.

┌─────────────┬──────────────────────┬───────────────────────────────────────────┐
│ Run │ e2e │ serial │
├─────────────┼──────────────────────┼───────────────────────────────────────────┤
│ 07-15 12:15 │ ❌ archive flake │ ❌ overlapping_uids + block_communication │
├─────────────┼──────────────────────┼───────────────────────────────────────────┤
│ 07-15 19:07 │ ✅ PASS │ ❌ infra (node never Ready) │
├─────────────┼──────────────────────┼───────────────────────────────────────────┤
│ 07-16 01:58 │ ✅ PASS (not listed) │ ❌ overlapping_uids + block_communication │
└─────────────┴──────────────────────┴───────────────────────────────────────────┘

Recommendation

Stop retesting the serial job — it can't go green on its own. The two blockers are pre-existing suite issues, provably not from this manifest-only change (still inert on the GCP self-managed profile), and e2e is now reliably green. The realistic paths:

  1. Fix the test suite (CCX/Insights QE): update test_communication.py's expected pattern from Post → Get to match the exporter's current behavior, and investigate why test_overlapping_uids times out on release-4.22 specifically. This unblocks all release-4.22 PRs, not just this one.

@opokornyy

opokornyy commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Claude does not think retesting will work, I will stop trying, I think @opokornyy you might need to take a look

Claude output

We need to get this PR - #1317 merged first then it should pass. I will run it when it is ready.

@opokornyy

Copy link
Copy Markdown
Contributor

/retest

@opokornyy

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 17, 2026
@opokornyy

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@TwoDCube

Copy link
Copy Markdown
Member

/retest

1 similar comment
@TwoDCube

Copy link
Copy Markdown
Member

/retest

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a600775 into openshift:release-4.22 Jul 17, 2026
13 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-98153
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98153 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #1313

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants