vSphere UPI: outdated README.md and terraform.tfvars.example

[salv-orlando]

Version

4.4.3

Platform:

None (UPI)

What happened?

Commit 27c03c8 overhauled the vSphere API by also changing the way in which ignition data are handled. However this is not reflect in terraforms.tfvars.example and in the README file.

For instance the README file still has not reference to route53 and PHP IPAM, and terraform.tfvars.example still references variables that do not exist anymore in the terraform configuration such as control_plane_ignition and compute_ignition.

What you expected to happen?

1. README to contain updated instructions
2. terraform.tfvars.example to contain the new required variables (e.g.: region) and omit the ones that do not exist anymore.

How to reproduce it (as minimally and precisely as possible)?

Not a functional issue, so no reproduction instructions.

Anything else we need to know?

Nope, It'll be awesome to have updated docs!

References

[abhinavdahiya]

Please feel free to send in an update! Will try to update the docs soon.

[dbarreda]

Any idea on what to put on the tfvars to skip the requirement for region? Right now it fails on terraform plan.

[DizzyThermal]

Running into the same issue with region being required for vSphere UPI cluster install.

This happens when running:

terraform apply -auto-approve

Output:

Error: Missing required argument

The argument "region" is required, but was not set.

[DizzyThermal]

For completeness:

Before hitting the required region argument (above comment), I also had to modify the names of the following values in terraform.tfvars:

bootstrap_ip -> bootstrap_ip_addresses
control_plane_ips -> control_plane_ip_addresses
compute_ip -> compute_ip_addresses

[tthebst]

@DizzyThermal For me it worked when I defined following environment variables.

$ export AWS_ACCESS_KEY_ID=acceseky
$ export AWS_SECRET_ACCESS_KEY=asecretkey
$ export AWS_DEFAULT_REGION=us-west-2

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.