OWNERS: Configure Prow with approver and reviewer information#71
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jul 26, 2018
Merged
OWNERS: Configure Prow with approver and reviewer information#71openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
retest-not-required-docs-only
size/M
Member
Author
I have some local WIP for this, but I'll wait until this PR and #72 land (to avoid conflicts) before filing a PR. |
Contributor
|
Why @openshift-ci-robot reacted with emoji?! How?! I need to know! 😄 LGTM |
Member
Author
Prow's heart plugin likes new |
Contributor
|
Nice! 👍 |
Member
Author
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
Most of the folks I've listed here are under Aaron in Red Hat, with Yifan being the installer lead. I've also included Alex and Clayton, who are higher up in Red Hat but still members of @openshift/installer. I'm guessing about roles, but we can always adjust later as we see fit. Approvers can also /lgtm [1], so there's no need to list them under 'reviewers' as well. The docs link in OWNERS is from [2]. While updating CONTRIBUTING.md to mention OWNERS (using wording based on [3]), I've also: * Added a line to make it clear that filing issues is helpful to (for folks who don't have the time or inclination to work up a PR). * Turned the unordered list into an ordered list. These entries happen sequentially, and an ordered list makes that more obvious. * Made "below" a link, to make finding the referenced content more convenient. * Shuffled words in the commit message format title to make it shorter. The references to 'make structure-check' are stale since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), but I've left fixing that to follow-up work. [1]: https://github.com/kubernetes/community/blob/4c0c2e9e659d2f989f3d23c3634c16bb099f3064/contributors/guide/owners.md#quirks-of-the-process [2]: kubernetes/kubernetes-template-project#15 [3]: https://github.com/kubernetes/kubernetes-template-project/blame/16f1588e6d4746876beb08cc64769657530d4872/CONTRIBUTING.md#L10
Member
Author
|
I've added @crawford and @smarterclayton as approvers, since they're also part of @openshift/installer. |
crawford
approved these changes
Jul 25, 2018
Contributor
|
/approve I’ll stick the label on if everyone is gtg on this. |
Contributor
|
/lgtm |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jul 30, 2018
The installer repo grew an OWNERS file with openshift/installer@49779c3e (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift/installer#71), so now it has approvers who are authorized to add the 'approved' label. This commit adjusts Tide to require that 'approved' label for installer merges. There are three Tide config groups with the same requirements: * The one I'm moving openshift/installer to with this commit. * One for openshift/origin. The origin repo was moved to its own section in 070b90a (Exclude merging to openshift/origin#master, 2018-04-09, openshift#761) to pick up an excludedBranches section. But that excludedBranches section was dropped in 2bd76e3 (reenable merging to origin:master, 2018-06-28, openshift#1021). However, we still want to keep origin in a separate section to make merge gating on rebases easier [1]. From Michalis [2]: When @openshift/sig-master want to land a kubernetes rebase in openshift/origin#master, we need to block merges on that branch and at the same time we don't want to be blocking merges elsewhere, hence origin has its own query. The installer repository doesn't need Kubernetes rebase gating, so it shouldn't go into this section. * One for openshift/online-registration and openshift/enterprise-images. This section was created in 5b004d2 (Single out hidden repo in tide queries, 2018-03-22, openshift#707). But the installer repo is public, so it shouldn't go into the hidden-repo section. [1]: openshift#1122 (comment) [2]: openshift#1122 (comment)
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 1, 2018
MAINTAINERS is obsolete since 49779c3 (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift#71). I've also dropped the email/IRC section, since as far as I know there are currently no public lists or IRC channels for installer discussion. Folks outside of Red Hat should communicate via GitHub issues and pull requests, and I think that's the expectation for projects that don't give alternatives in their CONTRIBUTING file.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 2, 2018
I can't spell. Typo is from 49779c3 (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift#71).
frobware
pushed a commit
to frobware/installer
that referenced
this pull request
Sep 17, 2018
MAINTAINERS is obsolete since 49779c3 (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift#71). I've also dropped the email/IRC section, since as far as I know there are currently no public lists or IRC channels for installer discussion. Folks outside of Red Hat should communicate via GitHub issues and pull requests, and I think that's the expectation for projects that don't give alternatives in their CONTRIBUTING file.
frobware
pushed a commit
to frobware/installer
that referenced
this pull request
Sep 17, 2018
I can't spell. Typo is from 49779c3 (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift#71).
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Bug 1906935: Delete resources when Provisioning CR is deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The folks I've listed here are all under @aaronlevel in Red Hat, with @yifan-gu being the installer lead. I'm guessing about roles, but we can always adjust later as we see fit.
Approvers can also
/lgtm, so there's no need to list them underreviewersas well.The docs link in
OWNERSis from kubernetes/kubernetes-template-project#15.While updating
CONTRIBUTING.mdto mentionOWNERS(using wording based on this), I've also:The references to 'make structure-check' are stale since d61abd4 (coreos/tectonic-installer#3137), but I've left fixing that to follow-up work.
Fixes #32. CC @paulfantom.