Skip to content

no-jira: Update hack scripts to set min go version to 1.26 - #10738

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
barbacbd:update_scripts_go-1.26
Aug 4, 2026
Merged

no-jira: Update hack scripts to set min go version to 1.26#10738
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
barbacbd:update_scripts_go-1.26

Conversation

@barbacbd

@barbacbd barbacbd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Update all container image references from golang:1.25 to golang:1.26 and bump minimum_go_version checks to 1.26 to match the go.mod toolchain requirement.

Summary by CodeRabbit

  • Chores
    • Updated the required Go version to 1.26 for builds and development tooling.
    • Standardized formatting, testing, security checks, validation, code generation, and vendor verification on Go 1.26.
    • No user-facing functionality changes.

Update all container image references from golang:1.25 to golang:1.26
and bump minimum_go_version checks to 1.26 to match the go.mod
toolchain requirement.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request explicitly references no jira issue.

Details

In response to this:

Update all container image references from golang:1.25 to golang:1.26 and bump minimum_go_version checks to 1.26 to match the go.mod toolchain requirement.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7c00f896-c92b-48fc-8d48-201c0abe6106

📥 Commits

Reviewing files that changed from the base of the PR and between 5f2b0d3 and a6f4c91.

📒 Files selected for processing (10)
  • hack/build-node-joiner.sh
  • hack/build.sh
  • hack/go-fmt.sh
  • hack/go-genmock.sh
  • hack/go-sec.sh
  • hack/go-test.sh
  • hack/go-vet.sh
  • hack/verify-capi-manifests.sh
  • hack/verify-codegen.sh
  • hack/verify-vendor.sh

📝 Walkthrough

Walkthrough

Changes

Go tooling update

Layer / File(s) Summary
Build version requirements
hack/build-node-joiner.sh, hack/build.sh
Build prerequisite checks now require Go 1.26.
Containerized tooling and verification
hack/go-fmt.sh, hack/go-genmock.sh, hack/go-sec.sh, hack/go-test.sh, hack/go-vet.sh, hack/verify-capi-manifests.sh, hack/verify-codegen.sh, hack/verify-vendor.sh
Containerized tooling and verification commands now use Go 1.26 images.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating hack scripts and the minimum Go version from 1.25 to 1.26.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only ten hack shell scripts for Go 1.26 references; it adds no Ginkgo tests or test-title expressions.
Test Structure And Quality ✅ Passed The PR changes only 10 hack shell scripts; the HEAD-parent diff contains no Go or Ginkgo test files, so this Ginkgo test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The diff changes only 10 hack shell scripts and adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-unsupported assumptions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only ten hack shell scripts and adds no Ginkgo or e2e tests, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed HEAD changes only ten .sh build/verification scripts, each only updating Go version references; no deployment, controller, manifest, or scheduling constraint changes exist.
Ote Binary Stdout Contract ✅ Passed The patch changes only Go version checks and Docker tags; no OTE binary, Ginkgo suite, or process-level stdout code is added or changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only ten .sh files for Go versions and container tags; it adds no Ginkgo e2e tests or networking code to assess.
No-Weak-Crypto ✅ Passed The patch changes only Go version checks and container image tags; no weak crypto, custom crypto, or secret comparisons appear in added lines or changed scripts.
Container-Privileges ✅ Passed Only hack scripts changed; added lines update Go versions and image tags, with no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The parent-to-HEAD diff contains only Go version and container image replacements. It adds no logging statements or sensitive-data terms.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhixson74 and rwsu August 3, 2026 14:45
@patrickdillon

Copy link
Copy Markdown
Contributor

/test verify-vendor

@patrickdillon

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/verified by local test

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@patrickdillon: This PR has been marked as verified by local test.

Details

In response to this:

/lgtm
/approve
/verified by local test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-azure-nat-gateway-single-zone

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 1669c8b into openshift:main Aug 4, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants