asset: Make warning message read for humans#2361
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 15, 2019
Merged
asset: Make warning message read for humans#2361openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
`ReleaseImage` is not a thing we reference elsewhere in user facing descriptions, a `release image` is.
openshift-ci-robot
added
size/XS
Member
|
Folks shouldn't be doing this anyway (which is why we warn), but sure... /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Oct 4, 2022
…sage This code-branch should be very rare, probably mostly internal testing. A chattier line in those situations isn't a big user-experience concern, and including the pullspec makes it easier for folks who are trying to understand internal-test results to figure out which pullspec was being used. The log line is originally from 456a373 (pkg: Use the sources from InstalConfig to create containers-registries.conf for bootstap, 2019-06-28, openshift#1910), and it was tweaked in cd0b70f (asset: Make warning message read for humans, 2019-09-15, openshift#2361), and neither of those make explicit arguments for why they didn't include the pullspec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReleaseImageis not a thing we reference elsewhere in user facingdescriptions, a
release imageis.