Use an internal ingress by default when the cluster is marked internal

[ironcladlou]

When the cluster is internal according to the install config's publishing field,
render an internal default ingresscontroller so that ingress remains consistent
with the intent for the entire cluster to be "internal".

This commit is part of the "User-defined Default Ingress Controller" enhancement
proposal[1] and implements the final user-facing component of the feature.

[1] https://github.com/openshift/enhancements/blob/master/enhancements/user-defined-default-ingress-controller.md

[ironcladlou]

/cc @abhinavdahiya

[ironcladlou]

/cc @mwoodson

[ironcladlou]

/retest

[ironcladlou]

@abhinavdahiya

I managed to test this on AWS using upi/aws/cloudformation/01_vpc.yaml to set up the VPC/subnets and then specifying publish: Internal in the install config. I ran the installer build from a bastion host within the VPC and came out the other side with a functional cluster with ingress using a load balancer with scope: Internal. Everything seems to be fine.

Hope that's a sufficient test. I can provide more details if necessary!

[ironcladlou]

All feedback addressed and verified with a manual test, PTAL.

[ironcladlou]

Rebased.

[abhinavdahiya]

@abhinavdahiya

I managed to test this on AWS using upi/aws/cloudformation/01_vpc.yaml to set up the VPC/subnets and then specifying publish: Internal in the install config. I ran the installer build from a bastion host within the VPC and came out the other side with a functional cluster with ingress using a load balancer with scope: Internal. Everything seems to be fine.

Hope that's a sufficient test. I can provide more details if necessary!

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[ironcladlou]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.