Skip to content

pkg/validate: '%s' -> %q for IP quoting - #2564

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:validate-q-for-quoting
Oct 25, 2019
Merged

pkg/validate: '%s' -> %q for IP quoting#2564
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:validate-q-for-quoting

Conversation

@wking

@wking wking commented Oct 24, 2019

Copy link
Copy Markdown
Member

Save a few characters and get safer quoting if the user gives us a candidate IP address that contains a single quote or some such.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2019
@wking
pkg/validate: '%s' -> %q for IP quoting
12a4544 
Save a few characters and get safer quoting if the user gives us a
candidate IP address that contains a single quote or some such.

The error messages I'm touching in the unit tests are fairly
redundant, but I didn't drop their inclusion of the validate.IP error
in case we make the error messages more specific later.
@wking
wking force-pushed the validate-q-for-quoting branch from 36121b0 to 12a4544 Compare October 24, 2019 23:18
@wking

wking commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

Fixed the unit failures with 36121b0e6 -> 12a4544.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 12a4544 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 12a4544 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti

pierreprinetti commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

/lgtm
😁

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 61e28a6 into openshift:master Oct 25, 2019
@wking
wking deleted the validate-q-for-quoting branch October 25, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74
@jstuever jstuever Awaiting requested review from jstuever

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-ci-robot @pierreprinetti @openshift-merge-robot