Skip to content

Bug 2012902: Include port fix - #577

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
MaysaMacedo:include-port-fix
Oct 11, 2021
Merged

Bug 2012902: Include port fix#577
openshift-merge-robot merged 2 commits into
openshift:masterfrom
MaysaMacedo:include-port-fix

Conversation

@MaysaMacedo

Copy link
Copy Markdown
Contributor

No description provided.

When the Pod has status Completed it has finalized
its job, consequently it's expected that Kuryr will
reclycle the Neutron Ports associated with it to be
used by other Pods. However, Kuryr is considering
Completed Pods as not scheduled and the event is skipped.
This commit fixes the issue by ensuring that Completed
Pods Ports recycle is done before checking for Scheduled
Pods.

Closes-Bug: #1945680
Change-Id: I23e7901fb016d59fa76762d1f24fee47974e72df
@openshift-ci
openshift-ci Bot requested review from dulek and gryf October 11, 2021 14:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@MaysaMacedo MaysaMacedo changed the title Include port fix Bug 2012902: Include port fix Oct 11, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 11, 2021
@openshift-ci

openshift-ci Bot commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 2012902, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2012902: Include port fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 11, 2021
@openshift-ci

openshift-ci Bot commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 2012902, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 11, 2021
@openshift-ci
openshift-ci Bot requested a review from eurijon October 11, 2021 14:51
@dulek

dulek commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-ci

openshift-ci Bot commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit e036df1 into openshift:master Oct 11, 2021
@openshift-ci

openshift-ci Bot commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@MaysaMacedo: All pull requests linked via external trackers have merged:

Bugzilla bug 2012902 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2012902: Include port fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
MaysaMacedo deleted the include-port-fix branch October 11, 2021 20:15
@MaysaMacedo

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

Copy link
Copy Markdown

@MaysaMacedo: new pull request created: #578

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants