Skip to content

4.19: Tests: Fix goToPodDetails helper flakiness#2081

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
kyoto:4.19-fix-goToPodDetails
Jul 23, 2026
Merged

4.19: Tests: Fix goToPodDetails helper flakiness#2081
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
kyoto:4.19-fix-goToPodDetails

Conversation

@kyoto

@kyoto kyoto commented Jun 16, 2026

Copy link
Copy Markdown
Member

Manual backport of #2076

Summary by CodeRabbit

  • Tests
    • Improved the pod-details navigation test helper to reliably select the intended pod entry by matching the provided pod name, then waiting for the corresponding pod-details link to appear before clicking. This enhances stability and reduces test flakiness.

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 04d57a85-d9b0-4b85-9917-ace62faaeb90

📥 Commits

Reviewing files that changed from the base of the PR and between 855ce5a and 27987fb.

📒 Files selected for processing (1)
  • tests/tests/lightspeed.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/tests/lightspeed.spec.ts

📝 Walkthrough

Walkthrough

The goToPodDetails test helper now filters resource rows by podName, waits up to 30 seconds for the matching details link to become visible, and clicks it.

Changes

Pod Details Navigation

Layer / File(s) Summary
Targeted pod link selection
tests/tests/lightspeed.spec.ts
Filters resource rows by podName, waits for the first matching details link, and clicks it.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: joaofula, syedriko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing the flaky goToPodDetails test helper in 4.19.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from JoaoFula and syedriko June 16, 2026 05:55
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/tests/lightspeed.spec.ts`:
- Around line 37-39: The test is currently clicking on the resource row
container itself (the result of page.locator(resourceRows).filter({ hasText:
podName })), which can lead to flaky behavior. Instead of clicking link.first()
directly, locate the resource-name anchor element within the filtered row and
click that specific anchor element to ensure reliable navigation. This targets
the actual clickable link rather than the container row.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5d0fdbc2-849e-4feb-ac5d-4fc7e0d5845e

📥 Commits

Reviewing files that changed from the base of the PR and between 946c356 and edf87fa.

📒 Files selected for processing (1)
  • tests/tests/lightspeed.spec.ts

Comment thread tests/tests/lightspeed.spec.ts Outdated
@kyoto

kyoto commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/retest

@kyoto
kyoto force-pushed the 4.19-fix-goToPodDetails branch from edf87fa to f3a1f61 Compare June 17, 2026 07:27
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2026
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@kyoto

kyoto commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

/retest

@kyoto kyoto added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@kyoto
kyoto force-pushed the 4.19-fix-goToPodDetails branch from f3a1f61 to 855ce5a Compare July 23, 2026 04:57
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@kyoto
kyoto force-pushed the 4.19-fix-goToPodDetails branch from 855ce5a to 27987fb Compare July 23, 2026 04:59
@kyoto kyoto added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 18ed66e into openshift:release-4.19 Jul 23, 2026
5 checks passed
@kyoto
kyoto deleted the 4.19-fix-goToPodDetails branch July 23, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant