Skip to content

OLS-3501: Remove generic tool call error alert message#2219

Open
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:remove-tool-error-alert
Open

OLS-3501: Remove generic tool call error alert message#2219
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:remove-tool-error-alert

Conversation

@kyoto

@kyoto kyoto commented Jul 14, 2026

Copy link
Copy Markdown
Member

This was just a generic error message that didn't add anything useful to the UX and could actually cause confusion due to the wording.

Summary by CodeRabbit

  • Bug Fixes
    • Removed the tool-failure inline error alert from the response tool modal.
    • Updated the tool-failure messaging so the modal proceeds directly to the standard content view.
  • Tests
    • Added coverage for the “tool error” modal behavior using a new streamed tool-error fixture.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 14, 2026

Copy link
Copy Markdown

@kyoto: This pull request references OLS-3501 which is a valid jira issue.

Details

In response to this:

This was just a generic error message that didn't add anything useful to the UX and could actually cause confusion due to the wording.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from joshuawilson and syedriko July 14, 2026 10:46
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 476c3b2d-7afd-4dad-82b9-eea11f7cb7e1

📥 Commits

Reviewing files that changed from the base of the PR and between 9a578ca and ba60381.

📒 Files selected for processing (4)
  • locales/en/plugin__lightspeed-console-plugin.json
  • src/components/ResponseToolModal.tsx
  • tests/support/fixtures.ts
  • tests/tests/lightspeed.spec.ts
💤 Files with no reviewable changes (2)
  • src/components/ResponseToolModal.tsx
  • locales/en/plugin__lightspeed-console-plugin.json

📝 Walkthrough

Walkthrough

The tool modal no longer displays its dedicated inline error alert, corresponding English translations are removed, and end-to-end coverage verifies tool error output and status rendering.

Changes

Tool error modal

Layer / File(s) Summary
Remove inline error alert and translations
src/components/ResponseToolModal.tsx, locales/en/plugin__lightspeed-console-plugin.json
The conditional error alert and its two English locale mappings are removed.
Add streamed tool error coverage
tests/support/fixtures.ts, tests/tests/lightspeed.spec.ts
A failing tool SSE fixture and serial test verify tool output, error status, and the absence of “Tool call rejected”.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: jira/valid-reference

Suggested reviewers: joshuawilson, syedriko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the generic tool call error alert message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Comment @coderabbitai help to get the list of available commands.

This was just a generic error message that didn't add anything useful to
the UX and could actually cause confusion due to the wording.

Also add an e2e test for the tool call error case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants