OLS-3501: Remove generic tool call error alert message#2219
Conversation
|
@kyoto: This pull request references OLS-3501 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe tool modal no longer displays its dedicated inline error alert, corresponding English translations are removed, and end-to-end coverage verifies tool error output and status rendering. ChangesTool error modal
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
This was just a generic error message that didn't add anything useful to the UX and could actually cause confusion due to the wording. Also add an e2e test for the tool call error case.
9a578ca to
ba60381
Compare
This was just a generic error message that didn't add anything useful to the UX and could actually cause confusion due to the wording.
Summary by CodeRabbit