Skip to content

Update kubernetes monorepo to v0.36.3 with controller-runtime v0.24.1 - #1877

Open
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:update-k8s-deps-v0.36.3
Open

Update kubernetes monorepo to v0.36.3 with controller-runtime v0.24.1#1877
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:update-k8s-deps-v0.36.3

Conversation

@raptorsun

@raptorsun raptorsun commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, k8s.io/apiextensions-apiserver from v0.35.4 to v0.36.3
  • Bump sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1 for compatibility
  • Go version updated from 1.25.11 to 1.26.0

Context

Supersedes #1762 which updated the k8s monorepo but failed CI (images, unit, and other jobs) because controller-runtime v0.23.3 is incompatible with k8s.io/client-go v0.36.3 — the ResourceEventHandlerRegistration interface in client-go v0.36 added a HasSyncedChecker method that controller-runtime v0.23.x doesn't implement.

Per the controller-runtime compatibility matrix, CR v0.24 is the version tested against k8s.io v0.36.

Test plan

  • go mod tidy succeeds
  • go build succeeds (no compilation errors)
  • make test — all unit tests pass
  • CI: ci/prow/images passes
  • CI: ci/prow/unit passes
  • CI: ci/prow/generate passes

Summary by CodeRabbit

  • Chores
    • Updated Kubernetes and controller-runtime components to newer versions.
    • Refreshed related indirect dependencies for improved compatibility and maintenance.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updates Kubernetes and controller-runtime module versions, adds the k8s.io/streaming indirect dependency, updates k8s.io/apiextensions-apiserver, and removes two obsolete indirect dependencies.

Changes

Kubernetes Dependency Refresh

Layer / File(s) Summary
Module dependency alignment
go.mod
Kubernetes core libraries and controller-runtime are upgraded; related indirect dependencies are added, updated, or removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: joshuawilson, bparees

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main dependency upgrades in go.mod, including Kubernetes modules and controller-runtime.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bparees and joshuawilson July 27, 2026 15:49
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2026
Bump k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, and
k8s.io/apiextensions-apiserver from v0.35.4 to v0.36.3. Also update
sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1 for
compatibility, since v0.23.x does not implement the HasSyncedChecker
method required by client-go v0.36's ResourceEventHandlerRegistration
interface.

Supersedes openshift#1762 which failed CI due to the missing controller-runtime
upgrade.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@raptorsun
raptorsun force-pushed the update-k8s-deps-v0.36.3 branch from 89314eb to 90d53b2 Compare July 28, 2026 12:05
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
go.mod (1)

11-14: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Document the new module/toolchain contract in AGENTS.md.

This structural dependency refresh should record the required Go 1.26 baseline and the mandated make test workflow for future contributors.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` around lines 11 - 14, Update AGENTS.md to document the new
module/toolchain contract: require Go 1.26 or later and instruct contributors to
use the mandated make test workflow. Keep the guidance aligned with the
dependency refresh represented by the updated Kubernetes and controller-runtime
versions.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@go.mod`:
- Around line 11-14: Update AGENTS.md to document the new module/toolchain
contract: require Go 1.26 or later and instruct contributors to use the mandated
make test workflow. Keep the guidance aligned with the dependency refresh
represented by the updated Kubernetes and controller-runtime versions.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: feb8f189-94da-432c-8df0-f4ea64181ad9

📥 Commits

Reviewing files that changed from the base of the PR and between c84e79d and 90d53b2.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum, !go.sum
📒 Files selected for processing (1)
  • go.mod

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant