Update kubernetes monorepo to v0.36.3 with controller-runtime v0.24.1 - #1877
Update kubernetes monorepo to v0.36.3 with controller-runtime v0.24.1#1877raptorsun wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughUpdates Kubernetes and controller-runtime module versions, adds the ChangesKubernetes Dependency Refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Bump k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, and k8s.io/apiextensions-apiserver from v0.35.4 to v0.36.3. Also update sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1 for compatibility, since v0.23.x does not implement the HasSyncedChecker method required by client-go v0.36's ResourceEventHandlerRegistration interface. Supersedes openshift#1762 which failed CI due to the missing controller-runtime upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
89314eb to
90d53b2
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
11-14: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDocument the new module/toolchain contract in
AGENTS.md.This structural dependency refresh should record the required Go 1.26 baseline and the mandated
make testworkflow for future contributors.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` around lines 11 - 14, Update AGENTS.md to document the new module/toolchain contract: require Go 1.26 or later and instruct contributors to use the mandated make test workflow. Keep the guidance aligned with the dependency refresh represented by the updated Kubernetes and controller-runtime versions.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Around line 11-14: Update AGENTS.md to document the new module/toolchain
contract: require Go 1.26 or later and instruct contributors to use the mandated
make test workflow. Keep the guidance aligned with the dependency refresh
represented by the updated Kubernetes and controller-runtime versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: feb8f189-94da-432c-8df0-f4ea64181ad9
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (1)
go.mod
|
@raptorsun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
k8s.io/api,k8s.io/apimachinery,k8s.io/client-go,k8s.io/apiextensions-apiserverfrom v0.35.4 to v0.36.3sigs.k8s.io/controller-runtimefrom v0.23.3 to v0.24.1 for compatibilityContext
Supersedes #1762 which updated the k8s monorepo but failed CI (
images,unit, and other jobs) becausecontroller-runtime v0.23.3is incompatible withk8s.io/client-go v0.36.3— theResourceEventHandlerRegistrationinterface in client-go v0.36 added aHasSyncedCheckermethod that controller-runtime v0.23.x doesn't implement.Per the controller-runtime compatibility matrix, CR v0.24 is the version tested against k8s.io v0.36.
Test plan
go mod tidysucceedsgo buildsucceeds (no compilation errors)make test— all unit tests passci/prow/imagespassesci/prow/unitpassesci/prow/generatepassesSummary by CodeRabbit