Skip to content

docs: fix up doc discrepancies - #1089

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
yuqi-zhang:doc-updates
Oct 8, 2019
Merged

docs: fix up doc discrepancies#1089
openshift-merge-robot merged 2 commits into
openshift:masterfrom
yuqi-zhang:doc-updates

Conversation

@yuqi-zhang

@yuqi-zhang yuqi-zhang commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

Note: this probably shouldn't be merged until master is branched for 4.3

- What I did
Fix various docs/comments and add snippet to test a release image.

- How to verify it

- Description for the changelog
Fix various formatting errors and typos in docs.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title docs: fix up doc discrepancies [4.3] docs: fix up doc discrepancies Aug 27, 2019
kikisdeliveryservice
kikisdeliveryservice approved these changes Aug 27, 2019
View reviewed changes

@kikisdeliveryservice kikisdeliveryservice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes, thank you!

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2019
kikisdeliveryservice
kikisdeliveryservice reviewed Aug 27, 2019
View reviewed changes
Comment thread docs/MachineConfigController.md Outdated
@kikisdeliveryservice

kikisdeliveryservice commented Sep 22, 2019

Copy link
Copy Markdown
Contributor

/retest

@kikisdeliveryservice

kikisdeliveryservice commented Sep 22, 2019

Copy link
Copy Markdown
Contributor

/skip

@runcom runcom removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title [4.3] docs: fix up doc discrepancies docs: fix up doc discrepancies Sep 28, 2019
@yuqi-zhang
daemon: fix comment on tainting
e10ea31 
We now annotate nodes on ssh access.
@yuqi-zhang
docs: fix various formatting
730a422 
Fix typos are formatting discrepancies. Also add snippet on how
to directly upgrade a cluster to a user-defined release image.
@yuqi-zhang

yuqi-zhang commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Updated and rebased

@runcom

runcom commented Oct 8, 2019

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

openshift-bot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot

openshift-bot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit f4bf2f4 into openshift:master Oct 8, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

@yuqi-zhang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 641ee27e901db10e331bf9f982c2c4d565b967f1 link /test e2e-aws-disruptive
ci/prow/e2e-aws-scaleup-rhel7 730a422 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ptalgulk01 pushed a commit to ptalgulk01/machine-config-operator that referenced this pull request May 15, 2026
@openshift-merge-robot
Merge pull request openshift#1089 from yuqi-zhang/doc-updates
eaa9b05 
docs: fix up doc discrepancies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow
1 more reviewer
@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yuqi-zhang @kikisdeliveryservice @runcom @openshift-ci-robot @openshift-bot @openshift-merge-robot