Skip to content

Build dockerfile cleanup - #1201

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
cgwalters:build-dockerfile-cleanup
Oct 21, 2019
Merged

Build dockerfile cleanup#1201
openshift-merge-robot merged 2 commits into
openshift:masterfrom
cgwalters:build-dockerfile-cleanup

Conversation

@cgwalters

@cgwalters cgwalters commented Oct 21, 2019

Copy link
Copy Markdown
Member

Smaller parts of #946

@cgwalters
build-sys: Fix make binaries to do all, change Dockerfile to use it
bc1c7ab 
Let's centralize more of our build logic in `Makefile` to keep
things consistent.
@cgwalters
build-sys: Order all COPY lines together
b7d0e03 
And add a `FIXME` to clarify that we should replace with a
glob when we can.

Prep for moving the `install` logic more fully into the `Makefile`.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2019
@runcom

runcom commented Oct 21, 2019

Copy link
Copy Markdown
Member

😍
/approve

@sinnykumari

sinnykumari commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

openshift-bot commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot

openshift-ci-robot commented Oct 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@cgwalters: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 b7d0e03 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom

runcom commented Oct 21, 2019

Copy link
Copy Markdown
Member

/skip

@openshift-merge-robot
openshift-merge-robot merged commit 1bddda1 into openshift:master Oct 21, 2019
ptalgulk01 pushed a commit to ptalgulk01/machine-config-operator that referenced this pull request May 15, 2026
@openshift-merge-robot
Merge pull request openshift#1201 from cgwalters/build-dockerfile-cle…
e62c6eb 
…anup

Build dockerfile cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb
@LorbusChris LorbusChris Awaiting requested review from LorbusChris

Assignees

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cgwalters @runcom @sinnykumari @openshift-ci-robot @openshift-bot @openshift-merge-robot