CNF-6362: feat: support generating cpu partitioning file from infra flag

[eggfoobar]

/hold
Needs PR: openshift/api#1284
EP: openshift/enhancements#1213

Signed-off-by: ehila ehila@redhat.com

- What I did

Add support for generating a machine config file that will configure kubelet for workload partitioning based off of the infrastructure flag. After some discussion with the installer team, MCO seems to be the best place to enforce the CPU Partitioning configuration cluster wide.

- How to verify it
When the Infrastructure status resource is set to cpuPartitioning: AllNodes, we will generate two new MCs for workload partitioning named 01-master-cpu-partitioning and 01-worker-cpu-partitioning that will create a configuration file for kubelet to use on start up.

apiVersion: config.openshift.io/v1
kind: Infrastructure
metadata:
  name: cluster
status:
  cpuPartitioning: AllNodes

- Description for the changelog

Add new generated MCs for workload partitioning based off of infrastructure status.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign jkyros for approval by writing /assign @jkyros in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/cc @yuqi-zhang

Hey Jerry, this is an updated PR from the previously closed one #3335 , the intention is the same but I took your suggestion and made it so MCO takes ownership of the MC for workload partitioning. While we wait for the PR for the API to go through, any thoughts or concerns on the implementation here?

[eggfoobar]

/cc @rphillips @mrunalp

[yuqi-zhang]

I think this generally looks like an ok direction, although I always hesitate towards adding additional sub-controllers and managed MCs, at least this one doesn't intersect with other kubelet configuration as far as I can tell.

Will review in-depth once you're ready. Maybe someone from the node team should take a look as well since they technically own the kubeletconfigcontroller

[yuqi-zhang]

So, this has a 01 prefix which means it is easily overwriteable by other MCs, which should be fine, since if I understand correctly, /etc/kubernetes/openshift-workload-pinning is the only file this will touch? And nothing else should be touching that file today?

[eggfoobar]

Actually, that file will be overwritten by other MCs later on. The intention is to set that file up originally to configure workload partitioning on the kubelet, then afterwords, when the user configures the PerformanceProfile via NTO, that file will be overwritten with CPUSet information that is defined in the PerformanceProfile. NTO is the one that will generate MCs to control that file afterwords.

[openshift-ci]

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	964d12c	link	true	/test e2e-aws
ci/prow/okd-scos-images	964d12c	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

@eggfoobar: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuqi-zhang]

@eggfoobar do you have any updates for this PR? Is this something we are still looking to do?

[eggfoobar]

Hey @yuqi-zhang, apologies, closing this out now that we've changed the approach in the EP.