CNF-6165: feat: added infra status for cpu partitioning feature #1284

eggfoobar · 2022-09-07T15:03:10Z

This PR adds a new Infrastructure status for identifying when a cluster is desired to have workload partitioning turned on.

openshift/enhancements#1213

Signed-off-by: ehila ehila@redhat.com

openshift-ci · 2022-09-07T15:03:58Z

Hello @eggfoobar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

jerpeter1 · 2022-09-14T18:06:35Z

/assign @deads2k

config/v1/types_infrastructure.go

deads2k · 2022-09-27T20:43:04Z

With the addition of an admission plugin that makes this field authoritative, I'm ok with this approach.

/approve

config/v1/types_infrastructure.go

JoelSpeed · 2022-09-30T08:08:45Z

/label tide/merge-method-squash

config/v1/types_infrastructure.go

JoelSpeed · 2022-10-03T11:50:45Z

/remove-label tide/merge-method-squash

rphillips · 2022-12-08T18:12:39Z

/lgtm

JoelSpeed

We have some integration testing to test YAML based interactions with our APIs, I think it would be good to get a test in for this new field to make sure the combination of defaulting and validation works as expected (docs)

config/v1/types_infrastructure.go

Signed-off-by: ehila <ehila@redhat.com> doc: updated comment docs Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2023-01-27T07:49:12Z

Thanks @JoelSpeed! The integration test was a great addition, please give it another look when you have some time.

JoelSpeed

One nit, but otherwise API changes LGTM

config/v1/techpreview.infrastructure.testsuite.yaml

updated unit test to use techpreview file updated integration tests to test default and validation for cpuPartitioning status Signed-off-by: ehila <ehila@redhat.com>

JoelSpeed · 2023-01-27T13:52:42Z

With the addition of an admission plugin that makes this field authoritative, I'm ok with this approach.

Was this done? Is there a WIP PR for it at least?

eggfoobar · 2023-01-27T14:19:30Z

With the addition of an admission plugin that makes this field authoritative, I'm ok with this approach.

Was this done? Is there a WIP PR for it at least?

That hasn't been added yet, there is a WIP PR openshift/kubernetes#1312 waiting for this to go in.

That effort is currently being tracked as part of CNF-5901 and API-1508

JoelSpeed · 2023-01-30T10:18:28Z

/lgtm

openshift-ci · 2023-01-30T10:21:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eggfoobar, JoelSpeed, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CFields651 · 2023-02-06T23:58:01Z

/label px-approved

sunilcio · 2023-02-07T06:18:42Z

/label qe-approved

eggfoobar · 2023-02-08T15:31:40Z

/label docs-approved

openshift-ci · 2023-02-08T15:52:01Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022

openshift-ci bot requested review from adambkaplan and jwforres September 7, 2022 15:08

eggfoobar changed the title ~~WIP: feat: added infra status for cpu partitioning feature~~ CNF-6165: feat: added infra status for cpu partitioning feature Sep 13, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022

eggfoobar force-pushed the cpu_partitioning_config branch from 4be26ae to dabd6ec Compare September 13, 2022 16:57

openshift-ci bot assigned deads2k Sep 14, 2022

deads2k reviewed Sep 14, 2022

View reviewed changes

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

deads2k reviewed Sep 14, 2022

View reviewed changes

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

deads2k reviewed Sep 14, 2022

View reviewed changes

config/v1/types_infrastructure.go Show resolved Hide resolved

eggfoobar force-pushed the cpu_partitioning_config branch from a738c53 to 8796e00 Compare September 27, 2022 16:51

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022

eggfoobar mentioned this pull request Sep 29, 2022

CNF-6357: feat: add CPU Partitioning flag into the install config openshift/installer#6430

Merged

JoelSpeed reviewed Sep 29, 2022

View reviewed changes

config/v1/types_infrastructure.go Show resolved Hide resolved

eggfoobar mentioned this pull request Sep 30, 2022

CNF-6362: feat: support generating cpu partitioning file from infra flag openshift/machine-config-operator#3355

Closed

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 30, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2022

eggfoobar force-pushed the cpu_partitioning_config branch from f56683a to a3cb2e5 Compare September 30, 2022 18:27

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2022

JoelSpeed reviewed Oct 3, 2022

View reviewed changes

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

openshift-ci bot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 3, 2022

eggfoobar force-pushed the cpu_partitioning_config branch from a3cb2e5 to e4208f3 Compare October 3, 2022 12:21

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2022

openshift-ci bot assigned rphillips Dec 8, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022

JoelSpeed reviewed Jan 25, 2023

View reviewed changes

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

config/v1/types_infrastructure.go Show resolved Hide resolved

feat: added infra status for cpu partitioning feature

50214e8

Signed-off-by: ehila <ehila@redhat.com> doc: updated comment docs Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the cpu_partitioning_config branch from 9445915 to eb16a13 Compare January 27, 2023 07:46

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023

eggfoobar force-pushed the cpu_partitioning_config branch from eb16a13 to 33b0032 Compare January 27, 2023 08:14

JoelSpeed reviewed Jan 27, 2023

View reviewed changes

config/v1/techpreview.infrastructure.testsuite.yaml Outdated Show resolved Hide resolved

eggfoobar force-pushed the cpu_partitioning_config branch from 33b0032 to 5cfca35 Compare January 27, 2023 13:28

test: update unit and integration tests

712a0ca

updated unit test to use techpreview file updated integration tests to test default and validation for cpuPartitioning status Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the cpu_partitioning_config branch from 5cfca35 to 712a0ca Compare January 27, 2023 13:46

openshift-ci bot assigned JoelSpeed Jan 30, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 6, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 7, 2023

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 8, 2023

openshift-merge-robot merged commit 942fb85 into openshift:master Feb 8, 2023

eggfoobar mentioned this pull request Feb 9, 2023

CNF-7382: feat: update to latest openshift/api openshift/cluster-config-operator#265

Closed

CNF-6165: feat: added infra status for cpu partitioning feature #1284

CNF-6165: feat: added infra status for cpu partitioning feature #1284

Uh oh!

Conversation

eggfoobar commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 7, 2022

Uh oh!

jerpeter1 commented Sep 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deads2k commented Sep 27, 2022

Uh oh!

Uh oh!

JoelSpeed commented Sep 30, 2022

Uh oh!

Uh oh!

JoelSpeed commented Oct 3, 2022

Uh oh!

rphillips commented Dec 8, 2022

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eggfoobar commented Jan 27, 2023

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoelSpeed commented Jan 27, 2023

Uh oh!

eggfoobar commented Jan 27, 2023

Uh oh!

JoelSpeed commented Jan 30, 2023

Uh oh!

openshift-ci bot commented Jan 30, 2023

Uh oh!

CFields651 commented Feb 6, 2023

Uh oh!

sunilcio commented Feb 7, 2023

Uh oh!

eggfoobar commented Feb 8, 2023

Uh oh!

openshift-ci bot commented Feb 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

eggfoobar commented Sep 7, 2022 •

edited

Loading