MCO-2427: move password, bootimages and cpms suites to longduration suite

[sergiordlr]

- What I did

Move the password, bootimage and controlplanemachineset tests to the longduration suite.

- How to verify it

The disruptive suites should not run those tests anymore, instead the should be executed by the longduration suite.

Summary by CodeRabbit

• Tests
  • Reclassified selected extended validation tests from the disruptive suite to the long-duration suite.
  • Consolidated ControlPlaneMachineSet coverage under the long-duration test grouping while preserving existing test labels and scenarios.
  • This improves test scheduling and categorization without changing product functionality or user-facing behavior.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@sergiordlr: This pull request references MCO-2427 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

- What I did

Move the password, bootimage and controlplanemachineset tests to the longduration suite.

- How to verify it

The disruptive suites should not run those tests anymore, instead the should be executed by the longduration suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91468a52-0baa-4733-9161-a18df3fff173

📥 Commits

Reviewing files that changed from the base of the PR and between 344534a and 19dda4c.

📒 Files selected for processing (3)

• test/extended-priv/mco_bootimages.go
• test/extended-priv/mco_controlplanemachineset.go
• test/extended-priv/mco_password.go

---

Walkthrough

The PR reclassifies MCO bootimages, ControlPlaneMachineSet, and password tests under the long-duration suite. ControlPlaneMachineSet disruptive cases are moved directly under the top-level test description, while its boot-image upgrade context remains.

Changes

Long-duration suite classification

Layer / File(s)	Summary
Update long-duration suite labels test/extended-priv/mco_bootimages.go, test/extended-priv/mco_controlplanemachineset.go, test/extended-priv/mco_password.go	Suite annotations are updated to use the long-duration marker.
Restructure ControlPlaneMachineSet suite grouping test/extended-priv/mco_controlplanemachineset.go	Disruptive test cases are moved under the top-level Describe, while the long-duration boot-image upgrade context remains.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	⚠️ Warning	mco_bootimages.go and mco_password.go use MachineSet/MachineConfig APIs but lack [apigroup:], [Skipped:MicroShift], or IsMicroShiftCluster guards.	Add MicroShift protection to those suites/tests (prefer [apigroup:machineconfiguration.openshift.io] or [Skipped:MicroShift]) before moving them to longduration.
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	mco_password.go hardcodes 127.0.0.1 in SSH validators, so the longduration test still assumes IPv4 localhost.	Replace the localhost literal with family-aware handling (e.g. localhost/::1 or IP-family detection) and validate in the IPv6 serial job.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: moving the password, bootimages, and cpms suites to longduration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The affected Ginkgo titles are static strings; only suite labels changed to longduration, with no dynamic names or generated values in test titles.
Test Structure And Quality	✅ Passed	Only suite labels/context placement changed; inspected tests already use per-test cleanup and explicit timeouts, and waitForComplete wraps PollUntilContextTimeout.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: control-plane suite calls SkipOnSingleNodeTopology; bootimages skips when workers can’t be scaled (including SNO); password suite uses a compact/SNO-compatible pool and node-local checks.
Topology-Aware Scheduling Compatibility	✅ Passed	Only Ginkgo test suite labels changed in test files; no manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	Touched files only change suite labels; no main/init/BeforeSuite stdout writes found, and shared logger writes to GinkgoWriter.
No-Weak-Crypto	✅ Passed	Diff only retags suites and moves tests; no added lines contain weak-crypto APIs or secret/token comparisons.
Container-Privileges	✅ Passed	Only Ginkgo suite-tag changes in Go test files; no privileged/hostPID/hostNetwork/securityContext fields or K8s manifests were added.
No-Sensitive-Data-In-Logs	✅ Passed	Only suite-tag changes were made; no new logging was added, and the touched files don’t log passwords/tokens/secrets or other sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[isabella-janssen]

/lgtm

Thank you @sergiordlr

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, sergiordlr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen,sergiordlr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/label acknowledge-critical-fixes-only

This just changes tests in the MCO-owned test suites, no functionality has changed, this is needed to improve the MCO's test health

[isabella-janssen]

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-ocl-part1
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-part1
/override ci/prow/e2e-gcp-op-part2
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-hypershift

No functionality changes, so these tests don't need to be run.

[openshift-ci]

@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2, ci/prow/e2e-gcp-op-part1, ci/prow/e2e-gcp-op-part2, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-ocl-part1
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-part1
/override ci/prow/e2e-gcp-op-part2
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-hypershift

No functionality changes, so these tests don't need to be run.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[isabella-janssen]

/verified later @sergiordlr

[openshift-ci-robot]

@isabella-janssen: This PR has been marked to be verified later by @sergiordlr.

Details

In response to this:

/verified later @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sergiordlr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.