Skip to content

USHIFT-7343: Exclude tuned* RPMs from fast-datapath repository#7009

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:fdp-exclude-tuned
Jul 9, 2026
Merged

USHIFT-7343: Exclude tuned* RPMs from fast-datapath repository#7009
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:fdp-exclude-tuned

Conversation

@pmtk

@pmtk pmtk commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Updated the fast-datapath repository settings to avoid installing tuned packages from that source.
    • This helps prevent conflicts with system-provided packages and keeps package behavior consistent across installs.

@pmtk pmtk changed the title Exclude tuned* RPMs from fast-datapath repository USHIFT-7343: Exclude tuned* RPMs from fast-datapath repository Jul 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-7343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jerpeter1 and pacevedom July 8, 2026 11:58
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 017f5b59-4ac4-40c3-9e99-01b88dc405f3

📥 Commits

Reviewing files that changed from the base of the PR and between d4dc9fc and 8f387c0.

📒 Files selected for processing (1)
  • test/package-sources-bootc/microshift-fast-datapath-rhel9.repo

Walkthrough

Adds an excludepkgs = tuned* setting with explanatory comments to the fast-datapath repository configuration file to prevent tuned packages from being sourced from that repo.

Changes

Repo Configuration Update

Layer / File(s) Summary
Exclude tuned packages from fast-datapath repo
test/package-sources-bootc/microshift-fast-datapath-rhel9.repo
Adds excludepkgs = tuned* and comments to prevent tuned packages from being installed from this repo.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: ready-for-human-review

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: excluding tuned* RPMs from the fast-datapath repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes a repo config file; no Ginkgo test titles or other test-name strings were added or modified.
Test Structure And Quality ✅ Passed No Ginkgo tests were changed; the PR only adds a repo config exclusion, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the changed *_test.go files are plain unit tests with no It/Describe/Context/When or MicroShift-unsupported APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a repo config file changed; no new/modified Ginkgo tests or SNO-assumption code was added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a yum repo file changed; no deployment, operator, or controller scheduling logic was added or modified.
Ote Binary Stdout Contract ✅ Passed Only a .repo config file changed; no main/init/TestMain/suite setup or stdout-writing code was touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a repo config file changed; no new Ginkgo/e2e tests, so IPv4/external-connectivity check is not applicable.
No-Weak-Crypto ✅ Passed Only a repo config changed; it adds an excludepkgs tuned* line and no weak-crypto code or secret comparisons.
Container-Privileges ✅ Passed PR only changes a yum repo file adding excludepkgs=tuned*; no container/K8s manifests or privilege fields were modified.
No-Sensitive-Data-In-Logs ✅ Passed Only a repo config changed; no logging code or sensitive-data handling was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 8, 2026
@pmtk

pmtk commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@kasturinarra

Copy link
Copy Markdown
Contributor

/lgtm
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@kasturinarra: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 2be4d6c into openshift:main Jul 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants