USHIFT-7365: add dual-stack v4/v6 scenario symmetry to c2cc CI jobs by agullon · Pull Request #7027 · openshift/microshift

agullon · 2026-07-09T13:01:32Z

Summary

Rename *@c2cc-dual-stack → *@c2cc-dual-stack-v4 to make explicit that IPv4 is the primary stack
Add el102-src@c2cc-dual-stack-v6 scenario (IPv6 primary, EL10)
Add el98-src@c2cc-dual-stack-v4 scenario (IPv4 primary, EL9)

Details

The c2cc CI jobs had asymmetric dual-stack coverage: el102 only had c2cc-dual-stack (IPv4 primary) and el98 only had c2cc-dual-stack-v6 (IPv6 primary). This PR adds the missing variants so both RHEL versions test both dual-stack orderings.

End state (13 scenarios)

Scenario	EL10	EL9
c2cc (base)	✅	✅
c2cc-ipsec	✅	✅
c2cc-ipv6	✅	✅
c2cc-dual-stack-v4	✅ (renamed)	✅ (new)
c2cc-dual-stack-v6	✅ (new)	✅
c2cc-disruptive	✅	✅
c2cc-upgrade-ok	—	✅

Test plan

Verify new scenario files match the structure of existing ones
Run c2cc CI job to validate new scenarios boot and pass

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Added dual-stack networking test scenarios for IPv4- and IPv6-primary configurations across three clusters.
- Added automated virtual machine setup, cleanup, host configuration, and test execution for these scenarios.
Documentation
- Clarified IP command selection behavior for dual-stack testing, including IPv4 and IPv6 handling.

openshift-ci-robot · 2026-07-09T13:01:36Z

@agullon: This pull request references USHIFT-7365 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Rename *@c2cc-dual-stack → *@c2cc-dual-stack-v4 to make explicit that IPv4 is the primary stack

Add el102-src@c2cc-dual-stack-v6 scenario (IPv6 primary, EL10)

Add el98-src@c2cc-dual-stack-v4 scenario (IPv4 primary, EL9)

Sort c2cc scenarios by expected duration (shortest first) for faster CI feedback

Details

The c2cc CI jobs had asymmetric dual-stack coverage: el102 only had c2cc-dual-stack (IPv4 primary) and el98 only had c2cc-dual-stack-v6 (IPv6 primary). This PR adds the missing variants so both RHEL versions test both dual-stack orderings.

Scenario ordering

Added sort_scenarios_shortest_first() to ci_phase_boot_and_test.sh that sorts c2cc scenarios by expected duration before passing them to GNU parallel. Based on observed CI runtimes: ipsec (~15min) < ipv6/base (~25min) < dual-stack (~26min) < upgrade (~30min) < disruptive (~35min).

End state (13 scenarios)

Scenario EL10 EL9

c2cc (base) ✅ ✅

c2cc-ipsec ✅ ✅

c2cc-ipv6 ✅ ✅

c2cc-dual-stack-v4 ✅ (renamed) ✅ (new)

c2cc-dual-stack-v6 ✅ (new) ✅

c2cc-disruptive ✅ ✅

c2cc-upgrade-ok — ✅

Test plan

Verify new scenario files match the structure of existing ones

Run c2cc CI job to validate new scenarios boot and pass

Verify scenario ordering in joblog matches expected shortest-first order

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-09T13:05:50Z

Note

Reviews paused

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds IPv4-primary and IPv6-primary dual-stack C2CC bootc scenario scripts, including cluster CIDRs, domains, VM lifecycle hooks, host configuration, and test execution. Clarifies IP command selection for dual-stack IPv4 and IPv6 testing.

Changes

Dual-stack C2CC bootc scenarios

Layer / File(s)	Summary
IPv4-primary dual-stack scenario `test/scenarios-bootc/c2cc/el98-src@c2cc-dual-stack-v4.sh`, `test/scenarios-bootc/c2cc/el102-src@c2cc-dual-stack-v4.sh`	Defines IPv4-primary and IPv6-secondary cluster networking, creates and removes dual-stack VMs, configures hosts, runs the basic suite, and documents IP command selection.
IPv6-primary dual-stack scenario `test/scenarios-bootc/c2cc/el102-src@c2cc-dual-stack-v6.sh`	Adds IPv6-primary cluster networking with IPv4 secondary CIDRs and runs the IPv6-focused C2CC suite through standard scenario hooks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

openshift/microshift#6954: Adds related C2CC dual-stack bootc scenarios and shared helper behavior.
openshift/microshift#7013: Consolidates C2CC suite paths used by the new scenarios.

Suggested reviewers: jerpeter1, pmtk

🚥 Pre-merge checks | ✅ 4 | ❌ 11

❌ Failed checks (1 warning, 10 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the PR’s main change: making c2cc dual-stack v4/v6 CI scenarios symmetric.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

vimauro

I haven't anything to flag, lgtm !

vimauro · 2026-07-09T14:26:54Z

/lgtm

agullon · 2026-07-09T14:35:42Z

/verified by CI

openshift-ci-robot · 2026-07-09T14:35:54Z

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-07-09T14:54:56Z

/hold

Make explicit that the existing dual-stack scenario uses IPv4 as the primary stack. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED

Add el102-src@c2cc-dual-stack-v6 (IPv6 primary, EL10) and el98-src@c2cc-dual-stack-v4 (IPv4 primary, EL9) so both RHEL versions test both dual-stack IP orderings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED

Add the same IP_FAMILY behavior comment that the v6 scenarios have, explaining how IP_CMD defaults to 'ip -4' for primary CIDRs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED

openshift-ci-robot · 2026-07-10T06:37:39Z

@agullon: This pull request references USHIFT-7365 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Rename *@c2cc-dual-stack → *@c2cc-dual-stack-v4 to make explicit that IPv4 is the primary stack

Add el102-src@c2cc-dual-stack-v6 scenario (IPv6 primary, EL10)

Add el98-src@c2cc-dual-stack-v4 scenario (IPv4 primary, EL9)

Details

The c2cc CI jobs had asymmetric dual-stack coverage: el102 only had c2cc-dual-stack (IPv4 primary) and el98 only had c2cc-dual-stack-v6 (IPv6 primary). This PR adds the missing variants so both RHEL versions test both dual-stack orderings.

End state (13 scenarios)

Scenario EL10 EL9

c2cc (base) ✅ ✅

c2cc-ipsec ✅ ✅

c2cc-ipv6 ✅ ✅

c2cc-dual-stack-v4 ✅ (renamed) ✅ (new)

c2cc-dual-stack-v6 ✅ (new) ✅

c2cc-disruptive ✅ ✅

c2cc-upgrade-ok — ✅

Test plan

Verify new scenario files match the structure of existing ones

Run c2cc CI job to validate new scenarios boot and pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-07-10T06:41:48Z

/hold cancel

pmtk · 2026-07-10T07:31:04Z

/lgtm

agullon · 2026-07-10T07:35:34Z

/verified by CI

openshift-ci-robot · 2026-07-10T07:35:46Z

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-07-10T09:23:39Z

@coderabbitai review

coderabbitai · 2026-07-10T09:23:56Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

agullon · 2026-07-10T09:42:10Z

@coderabbitai resolve

agullon · 2026-07-10T09:42:14Z

@coderabbitai full review

coderabbitai · 2026-07-10T09:42:30Z

✅ Action performed

Comments resolved and changes approved.

vimauro · 2026-07-10T10:46:26Z

/lgtm

openshift-ci · 2026-07-10T10:46:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pmtk, vimauro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [agullon,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vimauro · 2026-07-10T11:12:50Z

@coderabbitai ignore

coderabbitai · 2026-07-10T11:12:59Z

✅ Action performed

Reviews paused.

openshift-ci · 2026-07-10T12:09:38Z

@agullon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-tests-bootc-periodic-el10	`6864b74`	link	true	`/test e2e-aws-tests-bootc-periodic-el10`
ci/prow/e2e-aws-tests-bootc-periodic-arm-el10	`6864b74`	link	true	`/test e2e-aws-tests-bootc-periodic-arm-el10`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

agullon · 2026-07-10T12:12:15Z

/verified by CI

openshift-ci-robot · 2026-07-10T12:12:27Z

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon · 2026-07-10T12:13:17Z

I'll manually push Merge pull request button because:

CodeRabbit / ReviewStarted 5 hours ago — CodeRabbit Review Progress

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026

openshift-ci Bot requested review from eslutsky and jerpeter1 July 9, 2026 13:02

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2026

coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 9, 2026

coderabbitai Bot approved these changes Jul 9, 2026

View reviewed changes

agullon force-pushed the USHIFT-7365 branch from c00e533 to 6864b74 Compare July 9, 2026 13:33

coderabbitai Bot removed the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 9, 2026

vimauro approved these changes Jul 9, 2026

View reviewed changes

openshift-ci Bot assigned vimauro Jul 9, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 9, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2026

agullon added 3 commits July 10, 2026 08:37

USHIFT-7365: rename c2cc-dual-stack to c2cc-dual-stack-v4

9e02c48

Make explicit that the existing dual-stack scenario uses IPv4 as the primary stack. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED

agullon force-pushed the USHIFT-7365 branch from 6864b74 to caf4ff7 Compare July 10, 2026 06:37

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jul 10, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2026

openshift-ci Bot assigned pmtk Jul 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 10, 2026

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jul 10, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026

agullon force-pushed the USHIFT-7365 branch from a301115 to caf4ff7 Compare July 10, 2026 10:10

pacevedom mentioned this pull request Jul 10, 2026

OCPBUGS-98219: Move RBAC manifests to the services that own them #7029

Open

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 10, 2026

agullon merged commit 5967771 into openshift:main Jul 10, 2026
14 of 16 checks passed

Uh oh!

Conversation

agullon commented Jul 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

End state (13 scenarios)

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 9, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Scenario ordering

End state (13 scenarios)

Test plan

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning, 10 inconclusive)

Uh oh!

vimauro left a comment

Choose a reason for hiding this comment

Uh oh!

vimauro commented Jul 9, 2026

Uh oh!

agullon commented Jul 9, 2026

Uh oh!

openshift-ci-robot commented Jul 9, 2026

Uh oh!

agullon commented Jul 9, 2026

Uh oh!

openshift-ci-robot commented Jul 10, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

End state (13 scenarios)

Test plan

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

pmtk commented Jul 10, 2026

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

openshift-ci-robot commented Jul 10, 2026

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026

Uh oh!

vimauro commented Jul 10, 2026

Uh oh!

openshift-ci Bot commented Jul 10, 2026

Uh oh!

vimauro commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026

Uh oh!

openshift-ci Bot commented Jul 10, 2026

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

openshift-ci-robot commented Jul 10, 2026

Uh oh!

agullon commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

agullon commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 9, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

openshift-ci-robot commented Jul 10, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading