NO-ISSUE: Refactor RPM repository configuration common functionality#7080
Conversation
|
@ggiguash: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughChangesThe change centralizes RPM repository configuration in RPM repository configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant scenario_run_tests
participant configure_fast_datapath_repo
participant host1
participant subscription_manager
scenario_run_tests->>configure_fast_datapath_repo: Configure Fast Datapath
configure_fast_datapath_repo->>host1: Detect RHEL version
alt RHEL 9
configure_fast_datapath_repo->>subscription_manager: Enable fast-datapath
else Other RHEL version
configure_fast_datapath_repo->>host1: Write CDN repository file
end
Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/bin/scenario.sh`:
- Line 1271: The architecture checks at test/bin/scenario.sh lines 1271-1271 and
1304-1304 must query the remote VM rather than the local host. In both
locations, declare arch separately and assign it from run_command_on_vm host1
"uname -m", preserving shellcheck compliance.
- Line 1238: Quote the remote-shell variable expansions in test/bin/scenario.sh
at lines 1238-1238, 1290-1290, and 1344-1344: use single quotes around tmp_file
and repo_id at 1238-1238, tmp_file and ocp_repo_name at 1290-1290, and tmp_file
at 1344-1344.
- Around line 1221-1223: Update test/bin/scenario.sh at lines 1221-1223 to
declare cert, key, and tmp_file separately before assigning command-substitution
results. Apply the same separation to rhel_ver at line 1266, tmp_file at line
1279, rhel_ver at line 1299, and tmp_file at line 1334, preserving each existing
assignment and allowing command exit statuses to propagate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d935bdb1-aeff-49d8-bc4e-fb0c8233d871
📒 Files selected for processing (7)
test/bin/scenario.shtest/scenarios-bootc/el10/presubmits/el102-src@rpm-install.shtest/scenarios-bootc/el10/releases/el102@rpm-standard.shtest/scenarios-bootc/el9/presubmits/el98-src@rpm-install.shtest/scenarios/releases/el98@rpm-standard1.shtest/scenarios/releases/el98@rpm-standard2.shtest/scenarios/releases/el98@rpm-upgrade.sh
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Release tests are failing due to other reasons. |
|
/verified by ci |
openshift-ci-robot
added
the
verified
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic-el9, ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-arm-el9, ci/prow/e2e-aws-tests-bootc-release-el10, ci/prow/e2e-aws-tests-bootc-release-el9, ci/prow/e2e-aws-tests-release, ci/prow/e2e-aws-tests-release-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.22 |
|
@ggiguash: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ggiguash: #7080 failed to apply on top of branch "release-4.22": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Summary by CodeRabbit