USHIFT-4317: review and update docs/user/getting_started.md - #7121
Conversation
|
@copejon: This pull request references USHIFT-4317 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe getting-started guide now targets RHEL 9.8, updates the DVD ISO bootstrap reference, parameterizes MicroShift repository setup, installs only ChangesGetting Started Documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/getting_started.md`:
- Around line 84-91: Update the getting-started installation example’s
USHIFT_VER assignment from 4.19 to 4.22 so it matches the documented RHEL 9.8
environment; leave the repository enablement and installation commands
unchanged.
- Around line 84-92: Add the MicroShift 4.19 `oc` CLI download and link step
immediately after `sudo dnf install -y microshift` in the getting-started
instructions, before any MicroShift verification commands. Ensure the documented
CLI installation supports running `oc get pods -A` on the RHEL 9 path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d3c7863b-8f8a-4f3d-8de4-9c0520df740b
📒 Files selected for processing (1)
docs/user/getting_started.md
- docs/user/getting_started.md:87: Update USHIFT_VER from 4.19 to 4.22 to match RHEL 9.8 compatibility matrix Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7295ad5 to
579bdd2
Compare
|
/verified by ci |
|
@copejon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- Update product documentation URL (access.redhat.com → docs.redhat.com) - Update RHEL version references from 9.4 to 9.8 - Parameterize rhocp repo version with USHIFT_VER variable - Remove redundant openshift-clients from dnf install (already a hard dependency of the microshift RPM) - Fix "Confgure" typo - Add chmod 600 for pull secret to match all other docs and templates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- docs/user/getting_started.md:87: Update USHIFT_VER from 4.19 to 4.22 to match RHEL 9.8 compatibility matrix Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
579bdd2 to
d719d5d
Compare
|
/verified by ci |
|
@copejon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@copejon: This pull request references USHIFT-4317 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/getting_started.md`:
- Around line 84-92: Update the MicroShift installation instructions around
USHIFT_VER and the subscription-manager repo commands to set the RHEL release to
9.8 immediately after registration and before enabling the RPM repositories.
Preserve the existing repository enablement and package installation steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: a35e8cf2-f5b7-45ef-b6ef-669500f49cea
📒 Files selected for processing (1)
docs/user/getting_started.md
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
access.redhat.comtodocs.redhat.com(old URL returns 301)devenv_setup.mdand current targets)USHIFT_VERvariable instead of hardcoding 4.16openshift-clientsfromdnf install(it is a hardRequiresof themicroshiftRPM)sudo chmod 600 /etc/crio/openshift-pull-secretafter pull secret copy (every other doc and template in the repo sets this)Test plan
docs.redhat.com/en/documentation/red_hat_build_of_microshiftresolvesopenshift-clientsis still a hard dependency ofmicroshiftRPM (rpm -qR microshift | grep openshift-clients)🤖 Generated with Claude Code
Summary by CodeRabbit