USHIFT-6857: CI implementation: Support MicroShift V5.0 on RHEL 10.2 GA Implementation - #7140
USHIFT-6857: CI implementation: Support MicroShift V5.0 on RHEL 10.2 GA Implementation#7140agullon wants to merge 1 commit into
Conversation
|
@agullon: This pull request references USHIFT-7285 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. This pull request references USHIFT-7286 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. This pull request references USHIFT-7287 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughChangesLVMS upgrade scenarios
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Scenario
participant UpgradeVM
participant MicroShift
participant LVMS
Scenario->>UpgradeVM: Create and configure VM
UpgradeVM->>MicroShift: Wait for readiness
MicroShift->>LVMS: Create and validate workloads
Scenario->>UpgradeVM: Run OS upgrade
MicroShift->>LVMS: Verify workloads and resources
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
test/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard1.sh (1)
1-1: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winChange the shebangs, but do not add local shell options.
test/bin/scenario.shenablesset -euo pipefailbefore sourcing these files. Update all four first lines to#!/usr/bin/bash.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/scenarios-bootc/el10/releases/el102-y1`@el102-lrel@lvms-standard1.sh at line 1, Update the shebang on line 1 of all four specified release scenario files to use /usr/bin/bash, and do not add local shell options because test/bin/scenario.sh already enables them.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/scenarios-bootc/el10/releases/el102`@rpm-lvms-standard.sh:
- Line 1: Update the shebang at the top of the script from /bin/bash to
/usr/bin/bash, leaving the rest of the script unchanged.
- Line 46: Update the script header to use /usr/bin/bash and enable set -euo
pipefail. In the declaration around reponame, separate declaration from the
basename command substitution so failures propagate explicitly, then mark
reponame readonly after the assignment succeeds.
---
Nitpick comments:
In `@test/scenarios-bootc/el10/releases/el102-y1`@el102-lrel@lvms-standard1.sh:
- Line 1: Update the shebang on line 1 of all four specified release scenario
files to use /usr/bin/bash, and do not add local shell options because
test/bin/scenario.sh already enables them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 73c14f39-db70-4fea-8f78-898364f33be5
📒 Files selected for processing (5)
test/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard1.shtest/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard2.shtest/scenarios-bootc/el10/releases/el102@rpm-lvms-standard.shtest/scenarios-bootc/el10/releases/el98-y1@el102-lrel@lvms-standard.shtest/scenarios-bootc/el10/releases/el98-y2@el102-lrel@lvms-standard.sh
….22/4.21→5.0 on RHEL 10.2 Add 4 new CI release scenarios under scenarios-bootc/el10/releases/: - el102-y1@el102-lrel@lvms-standard.sh: bootc upgrade 4.22@10.2→5.0@10.2 - el98-y1@el102-lrel@lvms-standard.sh: bootc upgrade 4.22@9.8→5.0@10.2 - el98-y2@el102-lrel@lvms-standard.sh: bootc upgrade 4.21@9.8→5.0@10.2 - el102-y1@el102-lrel@rpm-lvms-standard.sh: RPM liveimg upgrade 4.22→5.0 on RHEL 10.2 Each scenario tests LVMS workload survival across the upgrade and runs both standard1 and standard2 suites for post-upgrade validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
|
/test e2e-aws-tests-release |
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
agullon
changed the title
|
@agullon: This pull request references USHIFT-6857 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
agullon
changed the title
2 participants
Summary
Add CI release scenarios for MicroShift upgrade paths to 5.0 on
RHEL 10.2, covering both same-OS and cross-OS version upgrades.
New upgrade scenarios (4 files):
el102-y1@el102-lrel@rpm-lvms-standard.shel102-y1@el102-lrel@lvms-standard.shel98-y1@el102-lrel@lvms-standard.shel98-y2@el102-lrel@lvms-standard.shTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit