[release-4.22] USHIFT-7428: remove origin pin workaround and update openshift-tests-private commit - #7144
Conversation
|
@agullon: This pull request references USHIFT-7428 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…commit The upstream fix for the cgroups/kubernetes dependency skew in openshift-tests-private has landed (OCPQE-32095). Remove the temporary origin pin workaround from fetch_tools.sh and bump OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT to a commit that includes the fix. Ref: USHIFT-7428 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
eaaad91 to
fc98a8b
Compare
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
sed -i 's|@main|@release-4.22|g' Makefileworkaround fromscripts/fetch_tools.shthat pinned openshift/origin to the release branch to avoid a cgroups/kubernetes dependency skewOPENSHIFT_TESTS_PRIVATE_REPO_COMMITintest/bin/common_versions.shto264a5b49369c2db96100374758c9c5cfb29a0259(latest onrelease-4.22, which includes the upstream fix)Context
The workaround was introduced in USHIFT-7427 to work around a build breakage caused by
opencontainers/cgroups v0.0.6incompatibility inopenshift-tests-private. The upstream fix has now landed via OCPQE-32095 (commit264a5b4onrelease-4.22), so the workaround is no longer needed.Test plan
ginkgotool build infetch_tools.shsucceeds without the origin pinextended-platform-testsbinary compiles and runs correctlyRef: USHIFT-7428
🤖 Generated with Claude Code