Skip to content

USHIFT-6749: [release-5.0] migrate 25 OTP storage tests to RF - #7295

Closed
agullon wants to merge 3 commits into
openshift:release-5.0from
agullon:USHIFT-6749-5.0
Closed

USHIFT-6749: [release-5.0] migrate 25 OTP storage tests to RF#7295
agullon wants to merge 3 commits into
openshift:release-5.0from
agullon:USHIFT-6749-5.0

Conversation

@agullon

@agullon agullon commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Backport of #7246 to release-5.0.

Migrates 25 MicroShift storage tests from openshift-tests-private (Go/Ginkgo) to Robot Framework.

Changes

  • Move existing storage tests from test/suites/storage/ to test/suites/storage1/
  • Add shared test infrastructure: StorageTemplates.py, storage.resource, 16 YAML templates
  • Add 25 test cases in test/suites/storage2/: provisioning.robot (18 tests) + snapshot-clone.robot (7 tests)
  • Update CI scenarios: presubmits run storage1/ only; releases run storage1/ + storage2/

Related

Jira

https://issues.redhat.com/browse/USHIFT-6749

🤖 Generated with Claude Code

@agullon
USHIFT-6749: move existing storage tests to storage1/
dc6c6a1 
Rename test/suites/storage/ to test/suites/storage1/ to make room
for the new OTP-migrated tests in storage2/. Update all presubmit
scenario scripts and run.sh to reference the new path.

Release scenarios are updated in a follow-up commit to add storage2/.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@agullon
USHIFT-6749: add storage test infrastructure for OTP migration
c90756f 
Add shared keywords and YAML templates to support the migration of
25 storage tests from openshift-tests-private to Robot Framework.

- StorageTemplates.py: renders YAML templates with ${KEY} placeholder
  substitution, validates no unreplaced placeholders remain
- storage.resource: reusable keywords for creating PVCs, Pods,
  Deployments, StorageClasses, StatefulSets, VolumeSnapshots,
  ResourceQuotas, and validating volume RW/exec/fstype/SELinux
- 16 YAML templates in test/assets/storage/ for all resource types

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@agullon
USHIFT-6749: migrate 25 OTP storage tests to Robot Framework
070be20 
Migrate 25 MicroShift storage tests from openshift-tests-private
(Go/Ginkgo) to Robot Framework under test/suites/storage2/.

provisioning.robot (18 tests):
  OCP-59668 (default SC, xfs, scale), OCP-59655 (WaitForFirstConsumer),
  OCP-59657 (Immediate binding), OCP-59658 (Block VolumeMode),
  OCP-59659 (Filesystem VolumeMode), OCP-59660 (online resize),
  OCP-59661 (StatefulSet), OCP-59662 (multiple PVCs),
  OCP-59663 (SC quota), OCP-59664 (namespace quota),
  OCP-59665 (delete unconsumed PVC), OCP-59666 (PVC protection),
  OCP-59667 (default SC selection), OCP-59669 (SELinux),
  OCP-59670 (change default SC), OCP-59671 (reclaim policy Retain),
  OCP-64231 (ephemeral volume), OCP-68580 (oc set volume)

snapshot-clone.robot (7 tests, requires thin pool):
  OCP-64839 (snapshot restore filesystem), OCP-64840 (snapshot restore
  block), OCP-64842 (snapshot content Delete policy), OCP-64843
  (snapshot content Retain policy), OCP-64856 (cross-SC snapshot),
  OCP-64857 (clone filesystem), OCP-64858 (clone block)

Release scenarios updated to run both storage1/ and storage2/.
Presubmit scenarios run storage1/ only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@agullon: This pull request references USHIFT-6749 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Backport of #7246 to release-5.0.

Migrates 25 MicroShift storage tests from openshift-tests-private (Go/Ginkgo) to Robot Framework.

Changes

  • Move existing storage tests from test/suites/storage/ to test/suites/storage1/
  • Add shared test infrastructure: StorageTemplates.py, storage.resource, 16 YAML templates
  • Add 25 test cases in test/suites/storage2/: provisioning.robot (18 tests) + snapshot-clone.robot (7 tests)
  • Update CI scenarios: presubmits run storage1/ only; releases run storage1/ + storage2/

Related

Jira

https://issues.redhat.com/browse/USHIFT-6749

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 74ee16f3-021a-40b3-b8de-dfecb6e27aa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2026
@agullon agullon mentioned this pull request Sep 1, 2026
Draft
6 tasks
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@agullon agullon closed this Sep 1, 2026
@agullon
agullon deleted the USHIFT-6749-5.0 branch September 1, 2026 14:56
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agullon @openshift-ci-robot