OU-1422: feat: update perses dependecies to allow to tag the OLS contributed panels#1045
OU-1422: feat: update perses dependecies to allow to tag the OLS contributed panels#1045jgbernalp wants to merge 1 commit into
Conversation
|
@jgbernalp: This pull request references OU-1422 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/cherry-pick release-coo-ocp-4.22 |
|
@jgbernalp: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughUpdates Perses package dependencies, adjusts Perses query definition types and wrappers to the newer client shapes, reshapes the timeseries definition input, and adds ai-assisted dashboard tagging before applying externally queued panels. ChangesPerses Dependency and Query Shape Updates
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/package.json`:
- Around line 77-82: The `@perses-dev` dependencies in web/package.json are pinned
to pre-release beta versions, so update the version entries for the affected
`@perses-dev/`* packages to stable releases before merging. Focus on the
dependency block containing `@perses-dev/components`, `@perses-dev/spec`,
`@perses-dev/dashboards`, `@perses-dev/explore`, `@perses-dev/plugin-system`, and
`@perses-dev/client`, and replace the beta pins with non-prerelease versions that
are compatible with the rest of the web build.
In `@web/src/components/dashboards/perses/ExternalPanelAddition.tsx`:
- Around line 85-91: The effect in ExternalPanelAddition is depending on the
full dashboardStore object, which causes unnecessary re-runs on every store
update and can feedback into the setMetadata update path. Remove dashboardStore
from the dependency array in the effect that uses queuedPanel,
dashboardStore.panelEditor, and dashboardStore.panelGroupOrder, and keep only
the specific stable fields and values actually read inside the effect.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4b11e625-8d9c-41a3-98f4-f310ff28c018
⛔ Files ignored due to path filters (1)
web/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
web/package.jsonweb/src/components/dashboards/perses/ExternalPanelAddition.tsxweb/src/components/dashboards/perses/PersesWrapper.tsxweb/src/components/ols-tool-ui/ShowTimeseries.tsx
…anels Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
0bf0ea8 to
2bf750c
Compare
|
@jgbernalp: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR upgrades the perses dependencies to the version that allow to set the dashboard metadata. This allows to set a tag in the dashboard for dashboards that receive panels from OLS.
Summary by CodeRabbit
ai-assistedtag is preserved when updating dashboard metadata.