Skip to content

build for rhel7 and rhel8 userspaces - #34

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
lsm5:multi-userspace
Nov 7, 2019
Merged

build for rhel7 and rhel8 userspaces#34
openshift-merge-robot merged 1 commit into
openshift:masterfrom
lsm5:multi-userspace

Conversation

@lsm5

@lsm5 lsm5 commented Oct 31, 2019

Copy link
Copy Markdown
Member

Dockerfile template from Doug Smith dosmith@redhat.com

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@dougbtv @mrunalp PTAL

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2019
@dougbtv

dougbtv commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

/hold

Thanks @lsm5 -- this is going to need a CNO PR that can handle copying the specific binary before this can be merged.

It might also require upstream changes to the Multus entrypoint. Currently, it copies its own binary, but, I don't think we can allow it to do that anymore. So we'll need to modify the entrypoint options to say "Don't copy your entrypoint anymore" and then have instructions in the CNO to copy the binary in this specific fashion.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2019

@knobunc knobunc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@lsm5

lsm5 commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

/retest

Dockerfile template from Doug Smith <dosmith@redhat.com>

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@dougbtv

dougbtv commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, knobunc, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@dougbtv

dougbtv commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@openshift-merge-robot
openshift-merge-robot merged commit c884bb7 into openshift:master Nov 7, 2019
@lsm5
lsm5 deleted the multi-userspace branch November 7, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants