build for rhel7 and rhel8 userspaces - #34
Conversation
|
/hold Thanks @lsm5 -- this is going to need a CNO PR that can handle copying the specific binary before this can be merged. It might also require upstream changes to the Multus entrypoint. Currently, it copies its own binary, but, I don't think we can allow it to do that anymore. So we'll need to modify the entrypoint options to say "Don't copy your entrypoint anymore" and then have instructions in the CNO to copy the binary in this specific fashion. |
|
/retest |
Dockerfile template from Doug Smith <dosmith@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, knobunc, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Dockerfile template from Doug Smith dosmith@redhat.com
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
@dougbtv @mrunalp PTAL