Fix ENVTESTPATH arch decided at Makefile-parse time on cold bin/

[kaovilai]

Fixes #2377

ifeq evaluates its $(shell ...) condition at Makefile-parse time, before any target's prerequisites run. On a cold bin/ (setup-envtest not yet installed), $(ENVTEST) list fails silently, the grep finds nothing, and ENVTESTPATH gets permanently redefined to force --arch=amd64 — regardless of host arch — even though setup-envtest is correctly installed for the host's native arch by the time the test recipe actually runs.

Moves the fallback entirely into the shell expression itself (still a recursively-expanded variable, so it's only evaluated when referenced in the test recipe, after envtest has installed the right arch).

Direct fix for oadp-1.3 — doesn't cherry-pick cleanly from the oadp-1.4 fix (oadp-1.3 predates the go-install-tool-versioned refactor), so opened separately rather than via cherry-pick bot.

Note

Responses generated with Claude

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5f68325e-dfe8-400a-935b-a1ecbda52213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.35%. Comparing base (b62bbe2) to head (ecad32d).

⚠️ Current head ecad32d differs from pull request most recent head b8aed6c

Please upload reports for the commit b8aed6c to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##           oadp-1.3    #2378   +/-   ##
=========================================
  Coverage     34.35%   34.35%           
=========================================
  Files            30       30           
  Lines          4949     4949           
=========================================
  Hits           1700     1700           
  Misses         3063     3063           
  Partials        186      186           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.14-e2e-test-cli-aws	b8aed6c	link	false	/test 4.14-e2e-test-cli-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.