OCPBUGS-8251: fix misleading --to-multi-arch messages

[savio87]

Summary

The oc adm upgrade --to-multi-arch command used the phrase "multi cluster architecture" in its success and error messages, which is misleading. Updated all three message strings to use the correct term "multi-architecture", consistent with the wording used in oc adm upgrade status.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-8251

Changes

• Flag help: "multi architecture" -> "multi-architecture"
• Already-requested error: "info: Update to multi cluster architecture has already been requested" -> "Cluster has already been requested to update to multi-architecture"
• Success message: "Requested update to multi cluster architecture" -> "Requested update to multi-architecture"

Summary by CodeRabbit

• Documentation
  • Updated upgrade command flags and status messages to consistently use “multi-architecture” terminology.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@savio87: This pull request references Jira Issue OCPBUGS-8251, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

The oc adm upgrade --to-multi-arch command used the phrase "multi cluster architecture" in its success and error messages, which is misleading. Updated all three message strings to use the correct term "multi-architecture", consistent with the wording used in oc adm upgrade status.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-8251

Changes

• Flag help: "multi architecture" -> "multi-architecture"
• Already-requested error: "info: Update to multi cluster architecture has already been requested" -> "Cluster has already been requested to update to multi-architecture"
• Success message: "Requested update to multi cluster architecture" -> "Requested update to multi-architecture"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: savio87
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/cli/admin/upgrade/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @savio87. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b095fe80-6792-4139-96de-fbe5fb2c89de

📥 Commits

Reviewing files that changed from the base of the PR and between 9c7ccc4 and be748e3.

📒 Files selected for processing (1)

• pkg/cli/admin/upgrade/upgrade.go

---

Walkthrough

The upgrade command updates its multi-architecture flag help text and status messages. The changes only revise terminology. Functional behavior remains unchanged.

Changes

Multi-architecture upgrade messaging

Layer / File(s)	Summary
Upgrade message terminology pkg/cli/admin/upgrade/upgrade.go	The --to-multi-arch help text and multi-architecture request messages now use consistent hyphenated terminology.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the fix to misleading --to-multi-arch messages, which matches the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only three static user-facing strings in upgrade.go and adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality	✅ Passed	The PR changes only three message strings in upgrade.go; no test files or Ginkgo test code changed, so these test-quality requirements do not apply.
Microshift Test Compatibility	✅ Passed	The pull request changes only three messages in upgrade.go and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The parent-to-HEAD diff changes only three strings in upgrade.go; it adds no Ginkgo e2e tests or multi-node assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only three CLI message strings in upgrade.go; it adds no manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR changes only three strings in regular CLI code; no OTE main, suite setup, or process-level stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only three CLI message strings in upgrade.go and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The PR patch changes only three user-facing strings in upgrade.go; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The PR changes only three user-facing strings in pkg/cli/admin/upgrade/upgrade.go; the diff contains no container or Kubernetes manifest privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only three static upgrade messages; none logs passwords, tokens, keys, PII, hostnames, session IDs, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[savio87]

Small messaging fix — updates "multi cluster architecture" to "multi-architecture" to match the wording in oc adm upgrade status. Could a maintainer update the target version on OCPBUGS-8251 and run /ok-to-test? Thanks!

[tchap]

Requested update to multi-architecture cluster sounds a bit more complete, thanks.