OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 - #2356
OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19#2356MrSanketkumar wants to merge 2 commits into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe pull request updates one application-generation test fixture and two IPv6 URL parsing test cases. ChangesNew application fixture
IPv6 parser fixtures
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/pipeline required |
|
Scheduling required tests: Scheduling tests matching the |
|
/test unit |
|
/pipeline required |
|
Scheduling required tests: Scheduling tests matching the |
|
/retest-required |
|
/lgtm |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, MrSanketkumar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-ovn-serial-1of2 |
|
retitle OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 |
|
/retitle OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-105503, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-105503, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-105503, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label jira/skip-dependent-bug-check |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-105503, which is valid. The bug has been moved to the POST state. 4 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is valid. The bug has been moved to the POST state. 4 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-105503, which is valid. 4 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is valid. 4 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-105503, which is valid. 4 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@MrSanketkumar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Fixes two pre-existing unit test failures in
pkg/helpers/newapp/newapptestand
pkg/helpers/source-to-image/gitthat block all PRs on release-4.19.Both fixes align with changes already applied on the
mainbranch.Changes
1. Fix TestNewAppRunAll/app_generation_using_context_dir
The test clones
openshift/sti-rubyand referencesContextDir: "3.1/test/rack-test-app", but the3.1/directory wasremoved from the upstream repository.
Fix: Update
ContextDirfrom"3.1/test/rack-test-app"to"3.3/test/rack-test-app"inpkg/helpers/newapp/newapptest/newapp_test.go.2. Fix TestParse (release-4.19 only)
Two test cases use IPv4-mapped IPv6 addresses (
::ffff:1.2.3.4) whichGo 1.23 rejects in
url.Parse()asinvalid IPv6 host.Fix: Replace
::ffff:1.2.3.4with the standard IPv6 documentationaddress
2001:db8::1inpkg/helpers/source-to-image/git/url_test.go.References
Summary by CodeRabbit