Skip to content

OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 - #2356

Open
MrSanketkumar wants to merge 2 commits into
openshift:release-4.19from
MrSanketkumar:fix-unity-test-path
Open

OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19#2356
MrSanketkumar wants to merge 2 commits into
openshift:release-4.19from
MrSanketkumar:fix-unity-test-path

Conversation

@MrSanketkumar

@MrSanketkumar MrSanketkumar commented Aug 10, 2026

Copy link
Copy Markdown

Summary

Fixes two pre-existing unit test failures in pkg/helpers/newapp/newapptest
and pkg/helpers/source-to-image/git that block all PRs on release-4.19.
Both fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

2. Fix TestParse (release-4.19 only)

Two test cases use IPv4-mapped IPv6 addresses (::ffff:1.2.3.4) which
Go 1.23 rejects in url.Parse() as invalid IPv6 host.

Fix: Replace ::ffff:1.2.3.4 with the standard IPv6 documentation
address 2001:db8::1 in pkg/helpers/source-to-image/git/url_test.go.

References

Summary by CodeRabbit

  • Tests
    • Updated integration test fixtures to use the current application repository context.
    • Refined IPv6 URL parsing test cases with standardized documentation addresses and expected host formatting.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3cd79b01-fb80-4a29-a4a4-b7a51c775e02

📥 Commits

Reviewing files that changed from the base of the PR and between b2a93a6 and 587956c.

📒 Files selected for processing (2)
  • pkg/helpers/newapp/newapptest/newapp_test.go
  • pkg/helpers/source-to-image/git/url_test.go

Walkthrough

The pull request updates one application-generation test fixture and two IPv6 URL parsing test cases.

Changes

New application fixture

Layer / File(s) Summary
Update application context fixture
pkg/helpers/newapp/newapptest/newapp_test.go
The test uses 3.3/test/rack-test-app instead of 3.1/test/rack-test-app.

IPv6 parser fixtures

Layer / File(s) Summary
Update IPv6 parsing cases
pkg/helpers/source-to-image/git/url_test.go
HTTP and SCP-style cases use 2001:db8::1 and verify bracketed host formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: gabemontero, ardaguclu

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both bug references and accurately summarizes the primary change: fixing pre-existing unit test failures on release-4.19.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only test data literals; affected tests use static Go test and t.Run names, with no Ginkgo titles or runtime values in titles.
Test Structure And Quality ✅ Passed The PR changes only fixture literals in standard testing.T table tests; it adds no Ginkgo It blocks, cluster waits, resources, or new setup and assertion issues.
Microshift Test Compatibility ✅ Passed The two commits only change data in existing standard Go tests; they add no Ginkgo e2e tests or new OpenShift API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The changes affect only standard Go unit tests; no new Ginkgo e2e tests or multi-node/HA assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only two Go unit-test files and updates test inputs; it adds no manifests, operators, controllers, replicas, affinity, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed The check is not applicable: the repository has no OTE/Ginkgo suite hooks or test-extension binary, and the PR changes only test fixtures.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only modifies existing Go tests; it adds no Ginkgo e2e tests or new IPv4/network connectivity assumptions.
No-Weak-Crypto ✅ Passed The two-commit patch changes only test paths and IPv6 literals; it adds no weak-crypto APIs, custom cryptography, or secret/token comparisons.
Container-Privileges ✅ Passed The PR changes only two Go test files and five test literals; no container/Kubernetes manifests or privilege-related settings were added.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes test URL and context-path literals; it adds no logging calls, logger imports, credentials, tokens, PII, or customer data.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@MrSanketkumar

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-builds

@MrSanketkumar

Copy link
Copy Markdown
Author

/test unit

@MrSanketkumar

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-builds

@MrSanketkumar

Copy link
Copy Markdown
Author

/retest-required

@ardaguclu

Copy link
Copy Markdown
Member

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 10, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, MrSanketkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@MrSanketkumar

Copy link
Copy Markdown
Author

/test e2e-aws-ovn-serial-1of2

@MrSanketkumar

Copy link
Copy Markdown
Author

retitle OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19

@MrSanketkumar

Copy link
Copy Markdown
Author

/retitle OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19

@openshift-ci openshift-ci Bot changed the title [DNM] fix:correct sti-ruby path for unit tests OCPBUGS-105504,OCPBUGS-105503: Fix pre-existing unit test failures on release-4.19 Aug 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-105504 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-105503, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-105503 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes two pre-existing unit test failures in pkg/helpers/newapp/newapptest
and pkg/helpers/source-to-image/git that block all PRs on release-4.19.
Both fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

2. Fix TestParse (release-4.19 only)

Two test cases use IPv4-mapped IPv6 addresses (::ffff:1.2.3.4) which
Go 1.23 rejects in url.Parse() as invalid IPv6 host.

Fix: Replace ::ffff:1.2.3.4 with the standard IPv6 documentation
address 2001:db8::1 in pkg/helpers/source-to-image/git/url_test.go.

References

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MrSanketkumar

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-63683 to target a version in 4.20.0, 4.20.z, but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-105503, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-73893 to target a version in 4.20.0, 4.20.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MrSanketkumar

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-63683 to target a version in 4.20.0, 4.20.z, but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-105503, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-73893 to target a version in 4.20.0, 4.20.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown

/label jira/skip-dependent-bug-check

@openshift-ci openshift-ci Bot added the jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. label Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-105503, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes two pre-existing unit test failures in pkg/helpers/newapp/newapptest
and pkg/helpers/source-to-image/git that block all PRs on release-4.19.
Both fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

2. Fix TestParse (release-4.19 only)

Two test cases use IPv4-mapped IPv6 addresses (::ffff:1.2.3.4) which
Go 1.23 rejects in url.Parse() as invalid IPv6 host.

Fix: Replace ::ffff:1.2.3.4 with the standard IPv6 documentation
address 2001:db8::1 in pkg/helpers/source-to-image/git/url_test.go.

References

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MrSanketkumar

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template

This pull request references Jira Issue OCPBUGS-105503, which is valid.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MrSanketkumar

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-105504, which is valid.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template

This pull request references Jira Issue OCPBUGS-105503, which is valid.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
Details

In response to this:

Summary

Fixes two pre-existing unit test failures in pkg/helpers/newapp/newapptest
and pkg/helpers/source-to-image/git that block all PRs on release-4.19.
Both fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

2. Fix TestParse (release-4.19 only)

Two test cases use IPv4-mapped IPv6 addresses (::ffff:1.2.3.4) which
Go 1.23 rejects in url.Parse() as invalid IPv6 host.

Fix: Replace ::ffff:1.2.3.4 with the standard IPv6 documentation
address 2001:db8::1 in pkg/helpers/source-to-image/git/url_test.go.

References

Summary by CodeRabbit

  • Tests
  • Updated integration test fixtures to use the current application repository context.
  • Refined IPv6 URL parsing test cases with standardized documentation addresses and expected host formatting.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@MrSanketkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 587956c link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants