Bug 1802615: Fix completion verification

[Bowenislandsong]

This fix helps with the verify test.

[openshift-ci-robot]

@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix completion verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Bowenislandsong: This pull request references Bugzilla bug 1802615, which is invalid:

• expected the bug to target the "4.3.z" release, but it targets "---" instead
• expected Bugzilla bug 1802615 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1802615: Fix completion verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bowenislandsong]

/bugzilla refresh

[openshift-ci-robot]

@Bowenislandsong: This pull request references Bugzilla bug 1802615, which is invalid:

• expected Bugzilla bug 1802615 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bowenislandsong]

/bugzilla refresh

[openshift-ci-robot]

@Bowenislandsong: This pull request references Bugzilla bug 1802615, which is invalid:

• expected dependent Bugzilla bug 1802620 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bowenislandsong]

/retest

[soltysh]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ecordell]

@soltysh Does this still need to be done? I see verify passing on other 4.3 PRs

[soltysh]

@soltysh Does this still need to be done? I see verify passing on other 4.3 PRs

If this is working fine, we can safely close the PRs and BZ, @Bowenislandsong mind doing this?

[Bowenislandsong]

@soltysh Does this still need to be done? I see verify passing on other 4.3 PRs

If this is working fine, we can safely close the PRs and BZ, @Bowenislandsong mind doing this?

That is weird. I looked up the problem it is stil there... then I ran make verify on my local machine

hack/verify-generated-completions.sh
hack/lib/../../hack/update-generated-completions.sh: line 7: _output/verify-generated-completions//bash/.files_generated: No such file or directory
Assets generated in _output/verify-generated-completions//bash
hack/lib/../../hack/update-generated-completions.sh: line 7: _output/verify-generated-completions//zsh/.files_generated: No such file or directory
Assets generated in _output/verify-generated-completions//zsh

there are still 2 slashes. I am not very sure why verify passed.

[soltysh]

there are still 2 slashes. I am not very sure why verify passed.

🤷‍♂️ I wouldn't care as long as this is working fine 😉
/close

[openshift-ci-robot]

@soltysh: Closed this PR.

In response to this:

there are still 2 slashes. I am not very sure why verify passed.

🤷‍♂️ I wouldn't care as long as this is working fine 😉
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.