-
Notifications
You must be signed in to change notification settings - Fork 1.9k
TELCODOCS-1707: Add Understanding assembly, modules, and diagrams #77078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TELCODOCS-1707: Add Understanding assembly, modules, and diagrams #77078
Conversation
|
@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.adoc
Outdated
Show resolved
Hide resolved
|
/test deploy-preview |
|
🤖 Mon Jun 17 14:02:00 - Prow CI generated the docs preview: |
|
@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
306e3c5 to
2fc1560
Compare
|
/label peer-review-needed |
|
/retest |
1 similar comment
|
/retest |
fe6cabc to
2fc1560
Compare
stevsmit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits. No major docs changes/revisions requested. Good job
edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.adoc
Show resolved
Hide resolved
| - name: example-extra-manifests | ||
| namespace: openshift-lifecycle-agent | ||
| oadpContent: <5> | ||
| - name: oadp-cm-example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a user-replaced variable and, if so, would it need to be <oadp_cm_example> ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are providing an example name throughout the procedure. It can be changed if needed but it's easier to copypaste if someone just wants to try the feature, so it's for convenience. "example" is in the name to make it obvious that it's not required to use the same name.
|
Telco RAN QE: Looks good to me. |
|
@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8b61ff9 to
34c14f9
Compare
|
@amolnar-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Content/PR look good to me. |
|
/cherry-pick enterprise-4.16 |
|
@stevsmit: new pull request created: #77562 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.16+
Issue: https://issues.redhat.com/browse/TELCODOCS-1707
Link to docs preview: https://77078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.html
QE review:
Additional information:
Dividing the original PR to smaller chunks. This is PR#2 from commit#2
Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.