Skip to content

Conversation

@amolnar-gh
Copy link
Contributor

@amolnar-gh amolnar-gh commented Jun 6, 2024

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://77078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.html

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2 from commit#2

Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2

The topicmap content is commented out until the relevant assemblies are added in separate PRs. See thread in review channel on Slack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2

Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2 from commit#2

Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh
Copy link
Contributor Author

/test deploy-preview

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 6, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://77078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.html

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2 from commit#2

Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1707-understanding-peer-review branch from 306e3c5 to 2fc1560 Compare June 6, 2024 21:14
@amolnar-gh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 6, 2024
@amolnar-gh
Copy link
Contributor Author

/retest

1 similar comment
@ShaunaDiaz
Copy link
Contributor

/retest

@rohennes rohennes force-pushed the TELCODOCS-1707-understanding-peer-review branch from fe6cabc to 2fc1560 Compare June 7, 2024 14:49
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2024
Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor nits. No major docs changes/revisions requested. Good job

- name: example-extra-manifests
namespace: openshift-lifecycle-agent
oadpContent: <5>
- name: oadp-cm-example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a user-replaced variable and, if so, would it need to be <oadp_cm_example> ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are providing an example name throughout the procedure. It can be changed if needed but it's easier to copypaste if someone just wants to try the feature, so it's for convenience. "example" is in the name to make it obvious that it's not required to use the same name.

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 10, 2024
@mpmaruthu
Copy link

Telco RAN QE: Looks good to me.
/Peri M

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024

@amolnar-rh: This pull request references TELCODOCS-1707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.16+

Issue: https://issues.redhat.com/browse/TELCODOCS-1707

Link to docs preview: https://77078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_based_upgrade/cnf-understanding-image-based-upgrade.html

QE review:

  • QE has approved this change.

Additional information:
Dividing the original PR to smaller chunks. This is PR#2 from commit#2

Only relevant topicmap content is added. See thread in review channel on Slack.
Xrefs are pointing to non-existent sections at the moment, so they are commented out until added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1707-understanding-peer-review branch from 8b61ff9 to 34c14f9 Compare June 17, 2024 13:52
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2024

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@stevsmit
Copy link
Member

Content/PR look good to me.

@stevsmit stevsmit merged commit ba243ea into openshift:main Jun 17, 2024
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.16

@openshift-cherrypick-robot

@stevsmit: new pull request created: #77562

Details

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants