Skip to content

OADP-5316-must-gather for 4.16-4.18#86301

Merged
xenolinux merged 1 commit intoopenshift:mainfrom
shdeshpa07:OADP-5316-must-gather-4.16-4.17
Jan 8, 2025
Merged

OADP-5316-must-gather for 4.16-4.18#86301
xenolinux merged 1 commit intoopenshift:mainfrom
shdeshpa07:OADP-5316-must-gather-4.16-4.17

Conversation

@shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Dec 16, 2024 •
edited
Loading

Jira

updated must-gather image for OCP 4.16 , 4.17, and 4.18. I have used OpenShift Operator Lifecycle doc to update the correct information. I have also attached the OADP screenshot.
image

Version

  • OCP 4.16 , 4.17, and 4.18 only

Preview

QE Review

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 16, 2024 •
edited
Loading

🤖 Wed Jan 08 05:50:42 - Prow CI generated the docs preview:
https://86301--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2024
@shdeshpa07 shdeshpa07 changed the title OADP-5316-must-gather for 4.16-4.17 OADP-5316-must-gather for 4.14-4.18 Dec 16, 2024
@shdeshpa07 shdeshpa07 changed the title OADP-5316-must-gather for 4.14-4.18 OADP-5316-must-gather for 4.16-4.18 Dec 16, 2024
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Dec 18, 2024

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Dec 18, 2024
@shdeshpa07 shdeshpa07 force-pushed the OADP-5316-must-gather-4.16-4.17 branch from b6947b1 to ed1b8b7 Compare December 18, 2024 06:51
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Dec 18, 2024

@anarnold97 - Could you please review the PR? Thanks.

@anarnold97
Copy link
Contributor

anarnold97 commented Dec 18, 2024

LGTM

weshayutin
weshayutin approved these changes Dec 20, 2024
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@amastbau
Copy link

amastbau commented Dec 30, 2024

/LGTM

@amastbau
Copy link

amastbau commented Dec 31, 2024

added comment
#86304 (comment)

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jan 2, 2025

added comment #86304 (comment)

Thank you Amos. I have worked on the review feedback.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jan 2, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 2, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 2, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Jan 2, 2025
xenolinux
xenolinux reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 2, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jan 6, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 6, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 6, 2025
dfitzmau
dfitzmau reviewed Jan 6, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2025

New changes are detected. LGTM label has been removed.

@shdeshpa07
OADP-5316-must-gather for 4.16-4.17
55df4ec 
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07 shdeshpa07 force-pushed the OADP-5316-must-gather-4.16-4.17 branch from b815f46 to 55df4ec Compare January 8, 2025 05:37
@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jan 8, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 8, 2025
xenolinux
xenolinux reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

_attributes/common-attributes.adoc
:op-system-base: RHEL
:op-system-base-full: Red Hat Enterprise Linux (RHEL)
:op-system-version: 9.x
:op-system-version-9: 9
Copy link
Contributor

@xenolinux xenolinux Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we write versions as 7.0, 8.0, 9.0. But I wouldn't hold merge for this.

Copy link
Contributor Author

@shdeshpa07 shdeshpa07 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll remember for the next time.

@xenolinux xenolinux merged commit 4a6fad9 into openshift:main Jan 8, 2025
2 checks passed
@xenolinux xenolinux removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 8, 2025
@xenolinux
Copy link
Contributor

xenolinux commented Jan 8, 2025

/cherrypick enterprise-4.17

@xenolinux
Copy link
Contributor

xenolinux commented Jan 8, 2025

/cherrypick enterprise-4.16

@xenolinux
Copy link
Contributor

xenolinux commented Jan 8, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2025

@xenolinux: new pull request created: #86796

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2025

@xenolinux: new pull request created: #86797

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2025

@xenolinux: new pull request created: #86798

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@dfitzmau dfitzmau dfitzmau left review comments

+1 more reviewer

@weshayutin weshayutin weshayutin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weshayutin weshayutin

@amastbau amastbau

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@shdeshpa07 @ocpdocs-previewbot @anarnold97 @amastbau @xenolinux @openshift-cherrypick-robot @weshayutin @dfitzmau