OADP-5316 must gather for 4.15 and 4.14 by shdeshpa07 · Pull Request #86304 · openshift/openshift-docs

shdeshpa07 · 2024-12-16T09:40:41Z

Jira

OADP-5316

Updated must-gather image for 4.15 and 4.14. I have used OpenShift Operator Lifecycle doc to update the correct information. I have also attached the OADP screenshot.

Version

OCP 4.15 and 4.14 only

Preview

OADP must-gather 4.15, 4.14

QE Review

QE has approved this change.

ocpdocs-previewbot · 2024-12-16T09:48:04Z

🤖 Tue Jan 07 13:04:08 - Prow CI generated the docs preview:
https://86304--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

shdeshpa07 · 2024-12-18T05:37:33Z

/label OADP

shdeshpa07 · 2024-12-18T07:18:56Z

@anarnold97 - Could you please review the PR? Thanks.

anarnold97 · 2024-12-18T12:35:39Z

LGTM

weshayutin

/LGTM

modules/migration-using-must-gather.adoc

openshift-ci · 2025-01-02T04:43:13Z

New changes are detected. LGTM label has been removed.

shdeshpa07 · 2025-01-02T05:48:51Z

/label peer-review-needed

xenolinux

One tiny nit; otherwise LGTM!

To get these changes merged into 4.14, you need to create a separate PR from the enterprise-4.14 branch because this PR is created from enterprise-4.15

modules/migration-using-must-gather.adoc

shdeshpa07 · 2025-01-06T12:16:31Z

/label merge-review-needed

shdeshpa07 · 2025-01-06T12:20:19Z

One tiny nit; otherwise LGTM!

To get these changes merged into 4.14, you need to create a separate PR from the enterprise-4.14 branch because this PR is created from enterprise-4.15

Hi merge reviewer :), I think we can cherrypick to 4.14 from this PR? Am I right? Please let me know if I need to create a separate PR. Thanks.

modules/migration-using-must-gather.adoc

Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>

openshift-ci · 2025-01-07T13:05:55Z

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shdeshpa07 · 2025-01-08T06:08:19Z

/label merge-review-needed

xenolinux

Merging

xenolinux · 2025-01-08T07:18:30Z

_attributes/common-attributes.adoc

 :op-system-base: RHEL
 :op-system-base-full: Red Hat Enterprise Linux (RHEL)
 :op-system-version: 9.x
+:op-system-version-9: 9


Suggested change

:op-system-version-9: 9

:op-system-version-9: 9.0

Usually we write versions as 7.0, 8.0, 9.0. But I wouldn't hold merge for this.

shdeshpa07 · 2025-01-08T08:21:41Z

@xenolinux - This needs to be merged into 4.14 as well. I thought we can cherrypick it to 4.14? Similar to how we merge into main and then cherrypick to other enterprise branches. Please let me know. Thanks.

xenolinux · 2025-01-08T08:27:35Z

@xenolinux - This needs to be merged into 4.14 as well. I thought we can cherrypick it to 4.14? Similar to how we merge into main and then cherrypick to other enterprise branches. Please let me know. Thanks.

@shdeshpa07 AFAIK we don't cherry pick from the enterprise branches. The best known practice is to create a PR from that specific enterprise (4.14 in this case) branch. Once you create a PR from enterprise-4.14, let me know I can merge it.

shdeshpa07 · 2025-01-08T08:30:54Z

@xenolinux - This needs to be merged into 4.14 as well. I thought we can cherrypick it to 4.14? Similar to how we merge into main and then cherrypick to other enterprise branches. Please let me know. Thanks.

@shdeshpa07 AFAIK we don't cherry pick from the enterprise branches. The best known practice is to create a PR from that specific enterprise (4.14 in this case) branch. Once you create a PR from enterprise-4.14, let me know I can merge it.

Got it. Thanks for the clarification. I'll create a separate PR and reference this one there. Thanks.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2024

shdeshpa07 changed the title ~~OADP-5316 must gather for 4.15~~ OADP-5316 must gather for 4.15 and 4.14 Dec 16, 2024

openshift-ci bot added the OADP Label for all OADP PRs label Dec 18, 2024

weshayutin approved these changes Dec 20, 2024

View reviewed changes

openshift-ci bot assigned weshayutin Dec 20, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024

amastbau reviewed Dec 30, 2024

View reviewed changes

modules/migration-using-must-gather.adoc Show resolved Hide resolved

amastbau mentioned this pull request Dec 31, 2024

OADP-5316-must-gather for 4.16-4.18 #86301

Merged

1 task

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025

shdeshpa07 force-pushed the OADP-5316-must-gather-for-4.15 branch from 4163e57 to cebbb57 Compare January 2, 2025 05:18

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 2, 2025

xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 2, 2025

xenolinux reviewed Jan 2, 2025

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 2, 2025

shdeshpa07 force-pushed the OADP-5316-must-gather-for-4.15 branch from 6a7e37d to 9bf947d Compare January 3, 2025 05:40

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 6, 2025

dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 6, 2025

dfitzmau reviewed Jan 6, 2025

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

dfitzmau reviewed Jan 6, 2025

View reviewed changes

modules/migration-using-must-gather.adoc Show resolved Hide resolved

OADP-5316 must gather for 4.15

e3bdc6d

Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>

shdeshpa07 force-pushed the OADP-5316-must-gather-for-4.15 branch from 1d5d651 to e3bdc6d Compare January 7, 2025 12:40

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 8, 2025

xenolinux reviewed Jan 8, 2025

View reviewed changes

xenolinux merged commit bd170f2 into openshift:enterprise-4.15 Jan 8, 2025
2 checks passed

xenolinux removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 8, 2025

shdeshpa07 mentioned this pull request Jan 8, 2025

OADP-5316-must-gather-4.14 #86800

Merged

1 task

Conversation

shdeshpa07 commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira

Version

Preview

QE Review

Uh oh!

ocpdocs-previewbot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shdeshpa07 commented Dec 18, 2024

Uh oh!

shdeshpa07 commented Dec 18, 2024

Uh oh!

anarnold97 commented Dec 18, 2024

Uh oh!

weshayutin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented Jan 2, 2025

Uh oh!

shdeshpa07 commented Jan 2, 2025

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shdeshpa07 commented Jan 6, 2025

Uh oh!

shdeshpa07 commented Jan 6, 2025

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Jan 7, 2025

Uh oh!

shdeshpa07 commented Jan 8, 2025

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

xenolinux Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shdeshpa07 commented Jan 8, 2025

Uh oh!

xenolinux commented Jan 8, 2025

Uh oh!

shdeshpa07 commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shdeshpa07 commented Dec 16, 2024 •

edited

Loading

ocpdocs-previewbot commented Dec 16, 2024 •

edited

Loading