Skip to content

CNV-61645: RN for disk hotplug with virtio-blk devices #100533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

CNV-61645: RN for disk hotplug with virtio-blk devices #100533

merged 1 commit into from
Oct 22, 2025

Conversation

@sbeskin-redhat
Copy link
Contributor

@sbeskin-redhat sbeskin-redhat commented Oct 15, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025 •
edited by openshift-ci bot
Loading

@sbeskin-redhat: This pull request references CNV-61645 which is a valid jira issue.

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-61645

CNV 4.20
OCP 4.20

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2025
@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch from fadaf72 to ae22fc8 Compare October 15, 2025 16:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 15, 2025 •
edited
Loading

🤖 Wed Oct 22 15:00:52 - Prow CI generated the docs preview:

https://100533--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025 •
edited by openshift-ci bot
Loading

@sbeskin-redhat: This pull request references CNV-61645 which is a valid jira issue.

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-61645

CNV 4.20
OCP 4.20

Preview:
https://100533--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html#virt-4-20-web_virt-4-20-release-notes
https://100533--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html#virt-4-20-deprecated_virt-4-20-release-notes
https://100533--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html#virt-4-20-notable-technical-changes_virt-4-20-release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch from ae22fc8 to d8f2cf3 Compare October 16, 2025 13:44
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2025
aglitke
aglitke approved these changes Oct 16, 2025
View reviewed changes
Copy link

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ousleyp ousleyp added CNV Label for all CNV PRs branch/enterprise-4.20 labels Oct 20, 2025
@ousleyp ousleyp added this to the Planned for 4.20 GA milestone Oct 20, 2025
@duyanyan
Copy link

duyanyan commented Oct 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch from 7a94aaa to 434b692 Compare October 20, 2025 14:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

New changes are detected. LGTM label has been removed.

abrennan89
abrennan89 reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly correcting to "hot plug" with no dash, per https://redhat-documentation.github.io/supplementary-style-guide/#hot-plug (I also just learned this recently 😄 )

I would also suggest using Renoa if you're not already, to keep the formatting consistent, but this to me isn't a blocker.

@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch 2 times, most recently from 3feb720 to 25ab109 Compare October 22, 2025 10:23
@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Oct 22, 2025

@abrennan89 Thank you, I've made the changes.

@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch from 407896d to 2159cce Compare October 22, 2025 10:59
sjhala-ccs
sjhala-ccs reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits. I can merge the PR after you make those updates. Thanks!

@sbeskin-redhat sbeskin-redhat force-pushed the CNV-61645_RN_for_Disk_hotplug_with_virtio_blk_devices branch from 2228eaf to 9bc1806 Compare October 22, 2025 14:40
@openshift-ci
Copy link

openshift-ci bot commented Oct 22, 2025

@sbeskin-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Oct 22, 2025

@sjhala-ccs Thank you, done

@sjhala-ccs sjhala-ccs merged commit 03032ab into openshift:enterprise-4.20 Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrennan89 abrennan89 abrennan89 left review comments

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

+1 more reviewer

@aglitke aglitke aglitke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@duyanyan duyanyan

Labels

branch/enterprise-4.20 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@sbeskin-redhat @openshift-ci-robot @ocpdocs-previewbot @duyanyan @aglitke @abrennan89 @sjhala-ccs @ousleyp @openshift-merge-robot