-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV - 64510: TP to GA boost on ARO #100987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV - 64510: TP to GA boost on ARO #100987
Conversation
|
lgtm |
|
Very straightforward change, nothing to complain about here :-) One thing I noticed, though, is that the heading of the section has an un-rendered |
|
@jherrman - Thanks for pointing that out! Just to be sure I fix the right spot, are you referring to the {VirtProductName} in the Azure Red Hat OpenShift (preview) heading (around line 78), or another heading? |
|
@Vaishali-gif-rh , no, I meant the "Preparing your cluster for {VirtProductName}" heading in https://100987--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html#compatible-platforms_preparing-cluster-for-virt In the source file, it is on line 3. |
4ad2840 to
4a7d778
Compare
|
@Vaishali-gif-rh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/CNV-64510
Link to docs preview:
https://100987--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html#compatible-platforms_preparing-cluster-for-virt
QE review:
Additional information: