Skip to content

Conversation

@Vaishali-gif-rh
Copy link
Contributor

@Vaishali-gif-rh Vaishali-gif-rh commented Oct 23, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2025
@geetikakay
Copy link

lgtm

@jherrman
Copy link
Contributor

Very straightforward change, nothing to complain about here :-)

One thing I noticed, though, is that the heading of the section has an un-rendered {VirtProductName} attribute, which I don't think should happen even in the preview.

@Vaishali-gif-rh
Copy link
Contributor Author

@jherrman - Thanks for pointing that out! Just to be sure I fix the right spot, are you referring to the {VirtProductName} in the Azure Red Hat OpenShift (preview) heading (around line 78), or another heading?

@jherrman
Copy link
Contributor

@Vaishali-gif-rh , no, I meant the "Preparing your cluster for {VirtProductName}" heading in https://100987--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html#compatible-platforms_preparing-cluster-for-virt

In the source file, it is on line 3.

@ousleyp ousleyp changed the base branch from enterprise-4.20 to main October 27, 2025 13:16
@ousleyp ousleyp changed the base branch from main to enterprise-4.20 October 27, 2025 13:17
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

@Vaishali-gif-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 4a7d778 link true /test validate-portal
ci/prow/validate-asciidoc 4a7d778 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants