[OSDOCS#16649]:Added permissions to required roles table in OSD WIF docs.

[AedinC]

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16649

Link to docs preview:
Workload Identity Federation authentication type procedure

Peer review:

• Peer reviewer has approved this change.

SME review:

• SME has approved this change.

QE review:
QE approval is not required for these changes.

Additional information:

[ocpdocs-previewbot]

🤖 Mon Nov 03 10:04:47 - Prow CI generated the docs preview:

https://100995--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_planning/gcp-ccs.html

[fmcdonal]

suggestion Role and description to align with other tables

[fmcdonal]

use comma; Role Administrator, required by the GCP client in the OCM CLI for creating custom roles.

[fmcdonal]

sorry also other use the shortened version of Administrator so maye just use Role Admin to align

[fmcdonal]

couple of suggestions but /LGTM, thanks Aedin

[AedinC]

@shreyansvm Can you please review this PR over next couple of days? Adding the fourth column to the table like we discussed made the table very wide. To combat this, I consolidated the existing first and last columns. This makes the first column a little crowded, however, the alternative is to have a very wide table that the users would need to use the scroll bar to view, or they would have to use the Expand button (like in this example).

Let me know what you think.

[svmrh]

Hi @AedinC : Sorry for the late reply. Your request from last week got buried in my mailbox, and I lost track of it until the "PR needs rebase" notification recently brought it to my attention.

The changes look fine. Could we also add the Expand button in there? It might help users to better visualize contents of the table.

This makes the first column a little crowded, however, the alternative is to have a very wide table that the users would need to use the scroll bar to view, or they would have to use the Expand button

cc: @rcampos2029 - FYI. Google has asked us to add granular permissions. For the automated checks implemented through the newly proposed OSD "Get Started" page in the Google Console, Google Engineering's best practice is to check for specific permissions and not predefined roles. Therefore, in addition to the role name, we are also adding granular permissions in a new column.

[AedinC]

Hi @AedinC : Sorry for the late reply. Your request from last week got buried in my mailbox, and I lost track of it until the "PR needs rebase" notification recently brought it to my attention.

The changes look fine. Could we also add the Expand button in there? It might help users to better visualize contents of the table.

This makes the first column a little crowded, however, the alternative is to have a very wide table that the users would need to use the scroll bar to view, or they would have to use the Expand button

cc: @rcampos2029 - FYI. Google has asked us to add granular permissions. For the automated checks implemented through the newly proposed OSD "Get Started" page in the Google Console, Google Engineering's best practice is to check for specific permissions and not predefined roles. Therefore, in addition to the role name, we are also adding granular permissions in a new column.

Thanks @svmrh. The expand button is added automatically. It doesn't show in the Prow preview build but it will be added on docs.redhat.

[openshift-ci]

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[AedinC]

@shreyansvm Will request this to be merged unless you have anything else to add? Thanks.

[svmrh]

No other comments. LGTM. Thanks @AedinC and team.

[jneczypor]

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

[openshift-cherrypick-robot]

@jneczypor: new pull request created: #101740

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jneczypor: new pull request created: #101741

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.