Skip to content

Conversation

@JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Nov 4, 2025

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-13364

Link to docs preview:
https://101658--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/openshift_sdn/configuring-egress-firewall.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Nov 4, 2025
@JoeAldinger JoeAldinger added merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 4, 2025
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoeAldinger JoeAldinger added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 5, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@jeana-redhat: Those labels are not set on the issue: merge-review-in-progress

In response to this:

LGTM :shipit:

/remove-label merge-review-in-progress
/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoeAldinger JoeAldinger merged commit 981a5f8 into openshift:enterprise-4.16 Nov 5, 2025
2 checks passed
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.14

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.13

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #101836

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #101658 failed to apply on top of branch "enterprise-4.13":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #101837

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: #101658 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-13364-egfw:fixes typo in SDN docs
Using index info to reconstruct a base tree...
M	modules/nw-egressnetworkpolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-egressnetworkpolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-egressnetworkpolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-13364-egfw:fixes typo in SDN docs

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoeAldinger
Copy link
Contributor Author

Only taking this back to 4.14 because of migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants