PR for SRVCOM-3999: Add a new “Integrating Service Mesh 3.x with OpenShift Serverless" section in the serverless docs #101668
Conversation
… ossm with serverless 3.x section the serverless docs
openshift-ci-robot
added
the
jira/valid-reference
|
@kaldesai: This pull request references SRVCOM-3999 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label serverless |
|
@kaldesai: This pull request references SRVCOM-3999 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
serverless
|
@kaldesai: This pull request references SRVCOM-3999 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
integrations/serverless-integrating-service-mesh/serverless-integrating-ossm-3-x-setup.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
| name: knative-serving | ||
| namespace: knative-serving | ||
| annotations: | ||
| serverless.openshift.io/disable-istio-net-policies-generation: "true" |
There was a problem hiding this comment.
@mvinkler could you pls verify if the setup can work without this annotation?
There was a problem hiding this comment.
I'm having some second thoughts, it isn't needed actually.
There was a problem hiding this comment.
I tried without the annotation and the revision for the service never got Ready
There was a problem hiding this comment.
That makes me wonder if it is needed for KnativeEventing and KnativeKafka as well. I checked for KnativeServing, three policies were created: allow-from-openshift-monitoring-ns, net-istio-webhook, webhook
|
|
||
| * If you want to use any domain name, including those which are not subdomains of the default {ocp-product-title} cluster domain, you must set up domain mapping for those domains. For more information, see the {ServerlessProductName} documentation about xref:../../knative-serving/config-custom-domains/create-domain-mapping.adoc#serverless-create-domain-mapping_create-domain-mapping[Creating a custom domain mapping]. | ||
|
|
||
| include::modules/serverless-ossm-external-certs.adoc[leveloffset=+1] |
There was a problem hiding this comment.
This module expect istio-system ns to exist in the step 4 but it is not in the prerequisities.
There was a problem hiding this comment.
Also I believe the wildcart certs should be created in knative-serving-ingress namespace, WDYT @dsimansk ?
There was a problem hiding this comment.
I checked and the secret needs to be in the knative-serving-ingress namespace for SM3
There was a problem hiding this comment.
Yes, thanks for pointing it out and checking.
| [role="_abstract"] | ||
| Before installing and configuring the {SMProductShortName} integration with {ServerlessProductShortName}, verify that the prerequisites have been met. | ||
|
|
||
| .Procedure |
There was a problem hiding this comment.
Check whether {SMProductName} istio-ingressgateway is exposed as type NodePort or LoadBalancer: section: istio-ingressgateway object does not exist at this point (we consider clean installation in this document?)
There was a problem hiding this comment.
Do you want me to remove that step then?
There was a problem hiding this comment.
@dsimansk I believe this prerequisite check makes no sense as you are just about to install SM, so why checking for istio-ingressgateway object in ns which doesn't exist at this point at all?
There was a problem hiding this comment.
Since @dsimansk did not have any input on this, let's just delete this prerequisity step.
There was a problem hiding this comment.
Yes, I believe it's meant to identify a potential conflict of pre-existing Service Mesh instance on the cluster. I agree we can assume a clean installation for now.
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
| name: knative-serving | ||
| namespace: knative-serving | ||
| annotations: | ||
| serverless.openshift.io/disable-istio-net-policies-generation: "true" |
There was a problem hiding this comment.
I tried without the annotation and the revision for the service never got Ready
modules/serverless-ossm-installing-and-configuring-openshift-serverless.adoc
Show resolved
Hide resolved
modules/serverless-ossm-verifying-the-ossm-3-x-integration.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-verifying-the-ossm-3-x-integration.adoc
Outdated
Show resolved
Hide resolved
| + | ||
| [source,terminal] | ||
| ---- | ||
| Hello Serverless! |
There was a problem hiding this comment.
With the multiarch image, the output is actually
{"artifact":"knative-showcase","greeting":"Welcome"}
There was a problem hiding this comment.
I have made the changes accodingly
modules/serverless-ossm-installing-and-configuring-openshift-service-mesh-3-x.adoc
Outdated
Show resolved
Hide resolved
modules/serverless-ossm-verifying-the-ossm-3-x-integration.adoc
Outdated
Show resolved
Hide resolved
|
For ServiceMesh 3, KnativeEventing also needs the (the same one that is on KnativeServing) |
|
@kaldesai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Affected versions:
serverless-docs-1.37Tracking JIRAs:
Doc preview:
Reviews: