Skip to content

Conversation

@tedaveryredhat
Copy link

@tedaveryredhat tedaveryredhat commented Nov 5, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2025

@tedaveryredhat: This pull request references OSDOCS-16311 which is a valid jira issue.

In response to this:

Version(s):
4.21

Issue:
https://issues.redhat.com/browse/OSDOCS-16311

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 5, 2025

@tedaveryredhat tedaveryredhat changed the title OSDOCS-16311:SR-IOV Concepts and Procedures (WIP) OSDOCS-16311:SR-IOV Concepts and Procedures Nov 6, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2025
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

@tedaveryredhat: This pull request references OSDOCS-16311 which is a valid jira issue.

In response to this:

Version(s):
4.21

Issue:
https://issues.redhat.com/browse/OSDOCS-16311

Link to docs preview:
https://101830--ocpdocs-pr.netlify.app/microshift/latest/microshift_networking/microshift-sriov.html

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

.Prerequisites

* You have the required RPM package or deployment manifests containing the SR-IOV device plugin and the CNI provider.
* You have configured the underlying network interface controllers (NICs) to expose VFs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this indicates we want the users to create the VFs beforehand, which isn't the case, the operator does that for us. In my experience, there wasn't any need to preconfigure the system in any way before deploying the operator, and OpenShift docs also do not list such a prerequisite, so I would remove this point altogether.


. Restart the {microshift-short} service to deploy the SR-IOV resources in the `sriov-network-operator` namespace.

. Deploy the `NetworkNodePolicy` custom resource definition (CRD) to specify the desired VF configuration based on the available hardware.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been referring to this wrong, to be exact, it's called SriovNetworkNodePolicy.

@openshift-ci
Copy link

openshift-ci bot commented Nov 26, 2025

@tedaveryredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants