Skip to content

Conversation

@agantony
Copy link
Contributor

@agantony agantony commented Nov 18, 2025

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-31310

Link to docs preview: https://102665--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-using-syslog-protocol.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.9
    • rhacs-docs-4.8

@agantony agantony added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.7 rhacs-docs-4.8 rhacs-docs-4.9 labels Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@agantony: This pull request references ROX-31310 which is a valid jira issue.

In response to this:

Version(s):
4.7+

Issue:
https://issues.redhat.com/browse/ROX-31310

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.9
    • rhacs-docs-4.8
    • rhacs-docs-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 18, 2025

🤖 Wed Nov 19 09:43:29 - Prow CI generated the docs preview:

https://102665--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-using-syslog-protocol.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@agantony: This pull request references ROX-31310 which is a valid jira issue.

In response to this:

Version(s):
4.7+

Issue:
https://issues.redhat.com/browse/ROX-31310

Link to docs preview: https://102665--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-using-syslog-protocol.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.9
    • rhacs-docs-4.8
    • rhacs-docs-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony force-pushed the ROX31310-rhacs-docs-main branch from a733b51 to 2bec60b Compare November 18, 2025 14:06
Copy link

@c-du c-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a peer review perspective. (with one requested fix)

@kcarmichael08 kcarmichael08 added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 18, 2025
ROX31310 Small corrections

ROX31310 Review comments
@agantony agantony force-pushed the ROX31310-rhacs-docs-main branch from 2bec60b to aaf7778 Compare November 19, 2025 09:34
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agantony
Copy link
Contributor Author

agantony commented Nov 20, 2025

Screenshot From 2025-11-20 13-26-26

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

@agantony: This pull request references ROX-31310 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-31310

Link to docs preview: https://102665--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-using-syslog-protocol.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.9
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony merged commit c2ce0e6 into openshift:rhacs-docs-main Nov 20, 2025
2 checks passed
@agantony
Copy link
Contributor Author

/cherrypick rhacs-docs-4.9

@agantony
Copy link
Contributor Author

/cherrypick rhacs-docs-4.8

@openshift-cherrypick-robot

@agantony: new pull request created: #102802

In response to this:

/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@agantony: new pull request created: #102803

In response to this:

/cherrypick rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 rhacs-docs-4.9 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants