-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[RHACS] [Docs] [rhacs-docs-main] ROX-31310: Updating syslog documentation #102665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHACS] [Docs] [rhacs-docs-main] ROX-31310: Updating syslog documentation #102665
Conversation
|
@agantony: This pull request references ROX-31310 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Wed Nov 19 09:43:29 - Prow CI generated the docs preview: |
|
@agantony: This pull request references ROX-31310 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a733b51 to
2bec60b
Compare
c-du
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a peer review perspective. (with one requested fix)
ROX31310 Small corrections ROX31310 Review comments
2bec60b to
aaf7778
Compare
|
@agantony: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@agantony: This pull request references ROX-31310 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick rhacs-docs-4.9 |
|
/cherrypick rhacs-docs-4.8 |
|
@agantony: new pull request created: #102802 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@agantony: new pull request created: #102803 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

Version(s):
4.8+
Issue:
https://issues.redhat.com/browse/ROX-31310
Link to docs preview: https://102665--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-using-syslog-protocol.html
SME review:
Additional information:
rhacs-docs-4.9rhacs-docs-4.8