OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex… #103104

dfitzmau · 2025-11-26T12:47:50Z

Version(s):
4.19+

Link to docs preview:

SME has approved this change (Chen Chen).
QE has approved this change (Hongan Li).

openshift-ci-robot · 2025-11-26T12:47:57Z

@dfitzmau: This pull request references Jira Issue OCPBUGS-37095, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-37095

Link to docs preview:

SME has approved this change.

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-11-26T12:54:24Z

🤖 Fri Nov 28 10:18:55 - Prow CI generated the docs preview:
https://103104--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

openshift-ci-robot · 2025-11-26T13:56:02Z

@dfitzmau: This pull request references Jira Issue OCPBUGS-37095, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-37095

Link to docs preview:

Creating a route with externally managed certificates

[]

SME has approved this change.

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dfitzmau · 2025-11-26T13:57:12Z

/retest

dfitzmau · 2025-11-26T14:44:43Z

networking/ingress_load_balancing/routes/secured-routes.adoc


-* For troubleshooting routes with externally managed certificates, check the {product-title} router pod logs for errors, see xref:../../../support/troubleshooting/investigating-pod-issues.adoc#investigating-pod-issues[Investigating pod issues].
-endif::openshift-rosa-hcp[]
+* xref:../../../nodes/clusters/nodes-cluster-enabling-features.adoc#nodes-cluster-enabling_nodes-cluster-enabling[Enabling features using feature gates]


xref:../../../nodes/clusters/nodes-cluster-enabling-features.adoc#nodes-cluster-enabling_nodes-cluster-enabling[Enabling features using feature gates] won't pass Prow.

https://docs.okd.io/4.20/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-enabling-features-cli_nodes-cluster-enabling

cchen666 · 2025-11-27T14:47:29Z

/LGTM

lihongan · 2025-11-28T02:41:10Z

modules/nw-ingress-route-secret-load-external-cert.adoc


 .Prerequisites

 * You must enable the `RouteExternalCertificate` feature gate.


The feature gate RouteExternalCertificate is promoted from Tech Preview to GA since 4.19, so maybe we need additional info here since the changes are for 4.16+.

openshift-ci · 2025-11-28T10:00:32Z

New changes are detected. LGTM label has been removed.

…ternal-cert.adoc

openshift-ci · 2025-11-28T10:20:02Z

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lihongan · 2025-11-28T10:49:02Z

LGTM, thank you!

mburke5678 · 2025-12-01T23:12:07Z

@dfitzmau A couple of places where the link text doesn't match the Enabling features using feature gates headline. Not sure if worth fixing up.

Understanding feature gates
Understanding feature gates
Enabling feature sets using the CLI
Understanding feature gates
Enabling feature sets using the web console

openshift-ci-robot · 2025-12-01T23:12:29Z

@dfitzmau: Jira Issue OCPBUGS-37095: All pull requests linked via external trackers have merged:

openshift/openshift-docs#103104

Jira Issue OCPBUGS-37095 has been moved to the MODIFIED state.

Details

In response to this:

Version(s):
4.19+

Issue:
OCPBUGS-37095

Link to docs preview:

Creating a route with externally managed certificates

Dedicated

ROSA classic

ROSA HCP

SME has approved this change (Chen Chen).

QE has approved this change (Hongan Li).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mburke5678 · 2025-12-01T23:12:48Z

/cherrypick enterprise-4.19

mburke5678 · 2025-12-01T23:12:54Z

/cherrypick enterprise-4.20

mburke5678 · 2025-12-01T23:12:59Z

/cherrypick enterprise-4.21

openshift-cherrypick-robot · 2025-12-01T23:13:34Z

@mburke5678: #103104 failed to apply on top of branch "enterprise-4.19":

Applying: OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-external-cert.adoc
.git/rebase-apply/patch:181: trailing whitespace.
[role="_abstract"] 
.git/rebase-apply/patch:254: trailing whitespace.
If `.spec.tls.externalCertificate` is not provided, the router uses default generated certificates. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	cicd/builds/running-entitled-builds.adoc
M	etcd/etcd-performance.adoc
M	installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-customizations.adoc
M	machine_configuration/index.adoc
M	machine_configuration/mco-coreos-layering.adoc
M	machine_configuration/mco-update-boot-images.adoc
M	nodes/clusters/nodes-cluster-enabling-features.adoc
M	nodes/nodes/nodes-update-boot-images.adoc
M	post_installation_configuration/cluster-tasks.adoc
M	support/remote_health_monitoring/about-remote-health-monitoring.adoc
Falling back to patching base and 3-way merge...
Auto-merging support/remote_health_monitoring/about-remote-health-monitoring.adoc
Auto-merging post_installation_configuration/cluster-tasks.adoc
Auto-merging nodes/nodes/nodes-update-boot-images.adoc
CONFLICT (content): Merge conflict in nodes/nodes/nodes-update-boot-images.adoc
Auto-merging nodes/clusters/nodes-cluster-enabling-features.adoc
Auto-merging machine_configuration/mco-update-boot-images.adoc
CONFLICT (content): Merge conflict in machine_configuration/mco-update-boot-images.adoc
Auto-merging machine_configuration/mco-coreos-layering.adoc
CONFLICT (content): Merge conflict in machine_configuration/mco-coreos-layering.adoc
Auto-merging machine_configuration/index.adoc
CONFLICT (content): Merge conflict in machine_configuration/index.adoc
Auto-merging installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-customizations.adoc
Auto-merging etcd/etcd-performance.adoc
Auto-merging cicd/builds/running-entitled-builds.adoc
CONFLICT (content): Merge conflict in cicd/builds/running-entitled-builds.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-external-cert.adoc

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-12-01T23:13:38Z

@mburke5678: #103104 failed to apply on top of branch "enterprise-4.20":

Applying: OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-external-cert.adoc
.git/rebase-apply/patch:181: trailing whitespace.
[role="_abstract"] 
.git/rebase-apply/patch:254: trailing whitespace.
If `.spec.tls.externalCertificate` is not provided, the router uses default generated certificates. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	machine_configuration/index.adoc
M	machine_configuration/mco-coreos-layering.adoc
Falling back to patching base and 3-way merge...
Auto-merging machine_configuration/mco-coreos-layering.adoc
CONFLICT (content): Merge conflict in machine_configuration/mco-coreos-layering.adoc
Auto-merging machine_configuration/index.adoc
CONFLICT (content): Merge conflict in machine_configuration/index.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-external-cert.adoc

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-12-01T23:13:47Z

@mburke5678: new pull request created: #103251

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 26, 2025

dfitzmau force-pushed the OCPBUGS-37095 branch from 9e5a7a3 to 14aad21 Compare November 26, 2025 12:58

dfitzmau commented Nov 26, 2025

View reviewed changes

dfitzmau force-pushed the OCPBUGS-37095 branch 5 times, most recently from 9cd0207 to 749b232 Compare November 26, 2025 16:27

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2025

dfitzmau force-pushed the OCPBUGS-37095 branch from 749b232 to b51275a Compare November 26, 2025 16:39

openshift-ci bot assigned cchen666 Nov 27, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025

lihongan reviewed Nov 28, 2025

View reviewed changes

dfitzmau force-pushed the OCPBUGS-37095 branch from 1a784a7 to 1eb73a1 Compare November 28, 2025 10:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2025

dfitzmau removed branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 labels Nov 28, 2025

dfitzmau force-pushed the OCPBUGS-37095 branch from 1eb73a1 to 83236e0 Compare November 28, 2025 10:09

OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex…

e9b401b

…ternal-cert.adoc

dfitzmau force-pushed the OCPBUGS-37095 branch from 83236e0 to e9b401b Compare November 28, 2025 10:10

dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 28, 2025

dfitzmau mentioned this pull request Nov 28, 2025

OCPBUGS-37095-18: Updated the prereqs on nw-ingress-route-secret- #103162

Merged

2 tasks

mburke5678 merged commit 9af8b6e into openshift:main Dec 1, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 1, 2025

[enterprise-4.21] : Updated the prereqs on nw-ingress-route-secret-load-ex… #103251

Merged

This was referenced Dec 2, 2025

[enterprise-4.20] OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex… #103255

Merged

[enterprise-4.19] OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex… #103256

Merged

dfitzmau removed the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 2, 2025


		.Prerequisites

		* You must enable the `RouteExternalCertificate` feature gate.

OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex… #103104

OCPBUGS-37095: Updated the prereqs on nw-ingress-route-secret-load-ex… #103104

Conversation

dfitzmau commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 26, 2025

Uh oh!

ocpdocs-previewbot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 26, 2025

Uh oh!

dfitzmau commented Nov 26, 2025

Uh oh!

dfitzmau Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

dfitzmau Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

cchen666 commented Nov 27, 2025

Uh oh!

lihongan Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 28, 2025

Uh oh!

openshift-ci bot commented Nov 28, 2025

Uh oh!

lihongan commented Nov 28, 2025

Uh oh!

mburke5678 commented Dec 1, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 1, 2025

Uh oh!

mburke5678 commented Dec 1, 2025

Uh oh!

mburke5678 commented Dec 1, 2025

Uh oh!

mburke5678 commented Dec 1, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dfitzmau commented Nov 26, 2025 •

edited

Loading

ocpdocs-previewbot commented Nov 26, 2025 •

edited

Loading