-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[CNV-76498] Add IBM Z node options #104763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CNV-76498] Add IBM Z node options #104763
Conversation
cfilleke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
7b34d15 to
090c286
Compare
|
@SNiemann15: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
| |Not applicable | ||
|
|
||
| |s390x | ||
| |KVM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table shown in the Jira indicates that what is shown in line 39 here should be zKVM (unless I'm reading the table wrong?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zKVM is one of those expression that IBM Z developers like to use but it's a "don't use" publicly name :-)
|
/cherrypick enterprise-4.21 |
|
@sjhala-ccs: new pull request created: #104889 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.21+
Issue: https://issues.redhat.com/browse/CNV-76498
Link to docs preview: https://104763--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/post_installation_configuration/virt-node-placement-virt-components.html
QE review:
Additional information: