OSDOCS#17890: Default enablement of signature mirroring #104833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
snarayan-redhat
force-pushed
the
OSDOCS-17890_signaturemirroring
branch
from
4c586fd to
5656fa8
Compare
|
🤖 Wed Jan 21 13:33:38 - Prow CI generated the docs preview: |
aguidirh
suggested changes
Jan 15, 2026
aguidirh
left a comment
aguidirh
left a comment
There was a problem hiding this comment.
Hi @snarayan-redhat,
Some suggestions from my side:
I would move the text below from Disabling signature mirroring for oc-mirror plugin v2 to Mirroring and verifying image signatures in oc-mirror plugin v2
By default, signature mirroring is enabled, the oc-mirror plugin v2 mirrors Sigstore tag-based signatures for the following images:
OpenShift Container Platform release images
Operator images
Additional images
Helm charts
Note:
If you do not provide a configuration file, the oc-mirror plugin v2 enables signature mirroring for all images.
To specify a custom configuration directory, use the --registries.d flag.
For more details, see the [containers-registries.d(5)](https://github.com/containers/image/blob/main/docs/containers-registries.d.5.md) manual.
Then on the Disabling signature mirroring for oc-mirror plugin v2
I would keep You can disable signature mirroring for all images by providing the --remove-signatures flag for the oc mirror command. and the Procedures 1 and 2.
snarayan-redhat
force-pushed
the
OSDOCS-17890_signaturemirroring
branch
from
5656fa8 to
b6d8734
Compare
openshift-ci
bot
added
size/M
openshift-ci
bot
added
the
do-not-merge/work-in-progress
snarayan-redhat
added
merge-review-needed
aguidirh
reviewed
Jan 16, 2026
aguidirh
left a comment
aguidirh
left a comment
There was a problem hiding this comment.
Hi @snarayan-redhat,
Only one comment before giving LGTM to this PR.
snarayan-redhat
removed
the
merge-review-needed
snarayan-redhat
force-pushed
the
OSDOCS-17890_signaturemirroring
branch
from
b6d8734 to
e07e3f4
Compare
aguidirh
approved these changes
Jan 19, 2026
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
snarayan-redhat
added
the
merge-review-needed
michaelryanpeter
added
the
merge-review-in-progress
Contributor
michaelryanpeter
left a comment
michaelryanpeter
left a comment
There was a problem hiding this comment.
LGTM. I am not merging because it still has the DRAT/WIP label applied.
michaelryanpeter
added
ok-to-merge
and removed
merge-review-in-progress
snarayan-redhat
force-pushed
the
OSDOCS-17890_signaturemirroring
branch
from
e07e3f4 to
89cfd69
Compare
aguidirh
suggested changes
Jan 21, 2026
snarayan-redhat
force-pushed
the
OSDOCS-17890_signaturemirroring
branch
from
89cfd69 to
a38d088
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@snarayan-redhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
Contributor
Author
|
/cherrypick enterprise-4.21 |
|
@snarayan-redhat: new pull request created: #105272 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
dfitzmau
pushed a commit
to dfitzmau/openshift-docs
that referenced
this pull request
Jan 23, 2026
…_signaturemirroring OSDOCS#17890: Default enablement of signature mirroring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.21
Issue: https://issues.redhat.com/browse/OSDOCS-17890
Link to docs preview: https://104833--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/about-installing-oc-mirror-v2.html#oc-mirror-signature-mirroring-procedure_about-installing-oc-mirror-v2
QE review:
Additional information: