-
Notifications
You must be signed in to change notification settings - Fork 1.9k
TELCODOCS-2622 Telco RAN RDS updates #105488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Fri Jan 30 14:04:44 - Prow CI generated the docs preview: https://105488--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-preparing-the-hub-cluster.html |
| -- | ||
| * Develop cloud-native network functions (CNFs) that conform to the latest version of link:https://redhat-best-practices-for-k8s.github.io/guide/[Red Hat best practices for Kubernetes]. | ||
| * Use SR-IOV for high performance networking. | ||
| * For information on the decrease in the default maximum open files soft limit for containers, see xref:../release_notes/ocp-4-21-release-notes.adoc#ocp-4-21-release-notes[{product-title} 4.21 release notes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules).
18e49a9 to
18ef87e
Compare
34d2916 to
686e414
Compare
dadf60c to
c7bff09
Compare
ac3b3fb to
f0bafe5
Compare
| PTP Operator,`ptp-operator/configuration/PtpConfigGmWpc.yaml`,Configures PTP grandmaster clock settings for hosts that have a single NIC. Dependent on cluster role.,No | ||
| PTP Operator,`ptp-operator/configuration/PtpConfigSlave.yaml`,Configures PTP settings for a PTP ordinary clock. Dependent on cluster role.,No | ||
| PTP Operator,`ptp-operator/configuration/PtpConfigDualFollower.yaml`,Configures PTP settings for a PTP ordinary clock with 2 interfaces in an active/standby configuration. Dependent on cluster role.,No | ||
| PTP Operator,`ptp-operator/configuration/PtpConfigTBCWpc.yaml`,Configures PTP as a Telcom boundary clock. Dependent on cluster role.,No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| PTP Operator,`ptp-operator/configuration/PtpConfigTBCWpc.yaml`,Configures PTP as a Telcom boundary clock. Dependent on cluster role.,No | |
| PTP Operator,`ptp-operator/configuration/PtpConfigTBCWpc.yaml`,Configures PTP as a Telecom boundary clock. Dependent on cluster role.,No |
Typo, right? Same for the next two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well spotted. Thank you
|
Great work! I see Lluis is reviewing this for style, just two minor issues regarding content from u/s to d/s:
"Representative SiteConfig CR to install single-node OpenShift with the RAN DU profile" And possibly this sentence needs to be updated because SiteConfig is removed now, not deprecated? " In earlier releases, a GitOps ZTP plugin supported the generation of installation CRs from SiteConfig CRs. This |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
Thanks @rohennes
|
| |==== | ||
| Component,Reference CR,Description,Optional | ||
| Cluster capabilities,`example-sno.yaml`,Representative SiteConfig CR to install single-node OpenShift with the RAN DU profile,No | ||
| Cluster capabilities,`example-sno.yaml`,Representative ClusterInstance CR to install single-node OpenShift with the RAN DU profile,No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{sno}' rather than the plain text product term 'single-node OpenShift', unless your use case is an exception.
|
@slovern: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
QE LGTM on Slack |
|
/cherrypick enterprise-4.21 |
|
@slovern: new pull request created: #105769 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
TELCODOCS-2622 Telco RAN RDS updates 4.21
Version(s): 4.21
Issue: https://issues.redhat.com/browse/TELCODOCS-2622
Link to docs preview: Telco RAN DU reference design specification
QE review:
Additional information: