TELCODOCS-2647: Fix AsciiDocDITA rule violations in PTP configuring-ptp assembly#106280
TELCODOCS-2647: Fix AsciiDocDITA rule violations in PTP configuring-ptp assembly#106280slovern merged 1 commit intoopenshift:mainfrom
Conversation
6e79f00 to
9a82af5
Compare
|
🤖 Fri Mar 13 13:03:31 - Prow CI generated the docs preview: |
|
@kquinn1204: This pull request references TELCODOCS-2647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
13dd63d to
b730e93
Compare
|
@kquinn1204: This pull request references TELCODOCS-2647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0319ad2 to
b80294f
Compare
|
@kquinn1204: This pull request references TELCODOCS-2647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…backport) Backport DITA fixes from PR openshift#106280 to enterprise-4.16. Includes 22 modules with fixes for short descriptions, callout transforms, block delimiters, and other AsciiDocDITA rule violations.
…backport) Backport DITA fixes from PR openshift#106280 to enterprise-4.18. Includes 24 modules with fixes for short descriptions, callout transforms, block delimiters, and other AsciiDocDITA rule violations.
…backport) Backport DITA fixes from PR openshift#106280 to enterprise-4.19. Includes 24 modules with fixes for short descriptions, callout transforms, block delimiters, and other AsciiDocDITA rule violations.
…backport) Backport DITA fixes from PR openshift#106280 to enterprise-4.17. Includes 22 modules with fixes for short descriptions, callout transforms, block delimiters, and other AsciiDocDITA rule violations.
| <1> Specify the required interfaces to start `ptp4l` as a boundary clock. For example, `ens5f0` synchronizes from a grandmaster clock and `ens5f1` synchronizes connected devices. | ||
| <2> Set `phc2sysOpts` with an empty string. | ||
|
|
||
| - `spec.profile.ptp4lConf` specify the required interfaces to start `ptp4l` as a boundary clock. For example, `ens5f0` synchronizes from a grandmaster clock and `ens5f1` synchronizes connected devices. |
slovern
left a comment
There was a problem hiding this comment.
A few comments on this one - mostly relating to how Claude has done the callouts
modules/cnf-getting-the-dpll-firmware-version-for-intel-800-series-nics.adoc
Show resolved
Hide resolved
modules/nw-ptp-configuring-linuxptp-services-as-grandmaster-clock-three-nic.adoc
Show resolved
Hide resolved
modules/ptp-configuring-linuxptp-services-as-boundary-clock-dual-nic.adoc
Show resolved
Hide resolved
4991bba to
b1fa069
Compare
Backport of PR openshift#106280 to enterprise-4.19. 23 files changed, 3 files excluded (not present on enterprise-4.19): - cnf-configuring-enhanced-log-filtering-for-linuxptp (4.20+) - cnf-configuring-log-reduction-for-linuxptp (4.20+) - nw-ptp-t-bc-t-tsc-holdover (4.20+) 1 conflict resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
modules/ptp-configuring-linuxptp-services-as-boundary-clock-dual-nic.adoc
Show resolved
Hide resolved
Backport of PR openshift#106280 to enterprise-4.16. 22 files included, 6 files excluded (not present on enterprise-4.16): - cnf-configuring-enhanced-log-filtering-for-linuxptp (4.20+) - cnf-configuring-log-reduction-for-linuxptp (4.20+) - nw-ptp-t-bc-t-tsc-holdover (4.20+) - nw-ptp-configuring-linuxptp-services-dual-port-oc (4.18+) - nw-ptp-holdover-in-a-grandmaster-clock (4.18+) - networking/advanced_networking/ptp/configuring-ptp.adoc (4.17+, 4.16 uses networking/ptp/ path) 5 conflicts resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite - nw-ptp-configuring-linuxptp-services-as-grandmaster-clock-dual-nic.adoc: applied NOTE delimiter and text fixes - nw-ptp-dual-wpc-hardware-config-reference.adoc: applied abstract + added pin format reference - nw-ptp-e810-hardware-configuration-reference.adoc: applied abstract rewrite - configuring-ptp.adoc: kept 4.16-correct xref paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve all AsciiDocDITA errors across 28 files in the configuring-ptp assembly to prepare for DITA conversion: - Add [role="_abstract"] short descriptions to 27 modules - Transform callout lists to definition/bulleted lists in 9 modules - Convert example block delimiters (====) to open blocks (--) for NOTE/IMPORTANT admonitions and remove [%collapsible] wrappers - Fix misspelled .Prerequisties block title in nw-ptp-device-discovery - Connect loose paragraphs to procedure steps with + continuations - Remove descriptive text from Additional resources link in assembly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d8eb4dd to
d6ac008
Compare
|
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
@slovern: new pull request created: #108324 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slovern: new pull request created: #108325 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slovern: #106280 failed to apply on top of branch "enterprise-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport of openshift#106280 to enterprise-4.19. 25 files included, 3 files excluded. 1 conflict(s) resolved. Excluded (not present on enterprise-4.19): - cnf-configuring-enhanced-log-filtering-for-linuxptp - cnf-configuring-log-reduction-for-linuxptp - nw-ptp-t-bc-t-tsc-holdover Conflicts resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite (replaced verbose description with [role="_abstract"] short description) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport of openshift#106280 to enterprise-4.18. 25 files included, 3 files excluded. 1 conflict(s) resolved. Excluded (not present on enterprise-4.18): - cnf-configuring-enhanced-log-filtering-for-linuxptp - cnf-configuring-log-reduction-for-linuxptp - nw-ptp-t-bc-t-tsc-holdover Conflicts resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport of openshift#106280 to enterprise-4.17. 23 files included, 5 files excluded. 1 conflict(s) resolved. Excluded (not present on enterprise-4.17): - cnf-configuring-enhanced-log-filtering-for-linuxptp - cnf-configuring-log-reduction-for-linuxptp - nw-ptp-configuring-linuxptp-services-dual-port-oc - nw-ptp-holdover-in-a-grandmaster-clock - nw-ptp-t-bc-t-tsc-holdover Conflicts resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport of openshift#106280 to enterprise-4.16. 22 files included, 6 files excluded. 4 conflict(s) resolved. Excluded (not present on enterprise-4.16): - cnf-configuring-enhanced-log-filtering-for-linuxptp - cnf-configuring-log-reduction-for-linuxptp - nw-ptp-configuring-linuxptp-services-dual-port-oc - nw-ptp-holdover-in-a-grandmaster-clock - nw-ptp-t-bc-t-tsc-holdover - networking/advanced_networking/ptp/configuring-ptp.adoc (exists at networking/ptp/ — no changes needed) Conflicts resolved: - cnf-configuring-log-filtering-for-linuxptp.adoc: applied abstract rewrite - nw-ptp-configuring-linuxptp-services-as-grandmaster-clock-dual-nic.adoc: applied ==== to -- delimiter fix, kept 4.16 E810-XXVDA4T product name - nw-ptp-dual-wpc-hardware-config-reference.adoc: applied abstract tag, kept 4.16 E810-XXVDA4T product name, added pin format reference content - nw-ptp-e810-hardware-configuration-reference.adoc: applied abstract tag, kept 4.16 E810-XXVDA4T product name Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
[TELCODOCS-2647]: Fix AsciiDocDITA rule violations in PTP configuring-ptp assembly
Version(s): 4.20+
Issue: https://issues.redhat.com/browse/TELCODOCS-2647
Link to docs preview: https://106280--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/configuring-ptp.html
QE review:
Additional information: Resolve all AsciiDocDITA errors across 28 files in the configuring-ptp assembly to prepare for DITA conversion:
Note: These are editorial/DITA-prep changes only - no technical content changes. A separate 4.16-specific PR will be created for the DITA conversion backport targeting only the modules that exist in 4.16.