OSDOCS-17203 Highlighting machine network parameter for bare metal UPI#107098
Open
bscott-rh wants to merge 1 commit intoopenshift:mainfrom
Open
OSDOCS-17203 Highlighting machine network parameter for bare metal UPI#107098bscott-rh wants to merge 1 commit intoopenshift:mainfrom
bscott-rh wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
size/S
|
🤖 Tue Feb 24 14:35:30 - Prow CI generated the docs preview: |
bscott-rh
force-pushed
the
OSDOCS-17203
branch
from
cc749f1 to
c26681f
Compare
Contributor
Author
|
/retest |
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
@jadhaj hi Jad, would you be able to take a look at this short bare metal docs bug? If not, could you tag a QE resource who would be able to? Thanks |
Contributor
|
This looks good to me, thank you for working on that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
4.16+
Issue:
https://issues.redhat.com/browse/OSDOCS-17203
Link to docs preview:
UPI Bare metal
Platform agnostic
QE review:
Also renamed a few parameters to meet the requirement to list the full nested param.