Skip to content

PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1#107665

Merged
briandooley merged 1 commit intoopenshift:serverless-docs-mainfrom
kaldesai:SRVLOGIC-781-OSL-1.37.0-to-1.37.1
Mar 30, 2026
Merged

PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1#107665
briandooley merged 1 commit intoopenshift:serverless-docs-mainfrom
kaldesai:SRVLOGIC-781-OSL-1.37.0-to-1.37.1

Conversation

@kaldesai
Copy link
Copy Markdown

@kaldesai kaldesai commented Mar 2, 2026

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 2, 2026

@kaldesai: This pull request references SRVLOGIC-781 which is a valid jira issue.

Details

In response to this:

Affected versions:
serverless-docs-1.37
serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 2, 2026

@kaldesai: This pull request references SRVLOGIC-781 which is a valid jira issue.

Details

In response to this:

Affected versions:
serverless-docs-1.37
serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 2, 2026

@kaldesai: This pull request references SRVLOGIC-781 which is a valid jira issue.

Details

In response to this:

Affected versions:
serverless-docs-1.37
serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2026
@kaldesai
Copy link
Copy Markdown
Author

kaldesai commented Mar 2, 2026

/label serverless

@openshift-ci openshift-ci Bot added the serverless Label for all Serverless PRs label Mar 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 2, 2026

@kaldesai: This pull request references SRVLOGIC-781 which is a valid jira issue.

Details

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaldesai kaldesai changed the title PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1 WIP PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1 Mar 2, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2026
Copy link
Copy Markdown

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview I can only see steps for devmode, any idea what is up?

@kaldesai
Copy link
Copy Markdown
Author

In the preview I can only see steps for devmode, any idea what is up?

Hello @domhanak, The PR is still WIP, it is not complete. I am changing the structure of the chapters with the new DITA migration rules. I wil let you know once the PR is complete.

@domhanak
Copy link
Copy Markdown

@kaldesai can't we publish the guide and change the structure in separate PR? 1.37.1 is out for quite some time and this upgrade docs is quite important.

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2026
@kaldesai kaldesai changed the title WIP PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1 PR for SRVLOGIC-781: Add a section for upgrading the OpenShift Serverless Logic Operator from 1.37.0 to 1.37.1 Mar 15, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2026
@kaldesai
Copy link
Copy Markdown
Author

@kaldesai can't we publish the guide and change the structure in separate PR? 1.37.1 is out for quite some time and this upgrade docs is quite important.

@domhanak I have upgraded the steps. Can you please take a look once again and review the content? Thank you!

@domhanak
Copy link
Copy Markdown

domhanak commented Mar 16, 2026

Hmm, the preview still shows only Deleting workflows with the dev profile chapter.

EDIT: seems to be working now. Looking

@openshift-ci-robot
Copy link
Copy Markdown

@kaldesai: This pull request references SRVLOGIC-781 which is a valid jira issue.

Details

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.38

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-781

Doc preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaldesai two nitpicks from my side only.
Great work!

Comment thread modules/serverless-logic-1-37-1-finalizing-the-upgrade.adoc Outdated
Copy link
Copy Markdown

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown

@ochromy ochromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review done.
Left 5 comments.
Otherwise LGTM. Build OK.

Great work, @kaldesai!

Comment thread modules/serverless-logic-upgrading-1-37-1-osl-operator.adoc
Comment thread modules/serverless-logic-upgrading-1-37-1-osl-operator.adoc
@wmedvede
Copy link
Copy Markdown

@kaldesai please hold-on this PR, I'll probalby have to do a small change in the procedure.

@wmedvede
Copy link
Copy Markdown

Hi @kaldesai many thanks for your work on this PR.
Unfortunatelly we have detected two extra steps to add to guide, but the good news is that all the current content doesn't change, we must basically add one step at the begining of the migration, and one at the end.

This is the midstream PR, openshift-knative/docs#134 and this is the preview page:

https://deploy-preview-134--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/cloud/operator/upgrade-serverless-operator/upgrade_1_37_0_to_1_37_1

And this is what we need to incorporate to the guide.

  1. As part of the Preparing for the 1.37.0 to 1.37.1 upgrade, the first step must be:

Increase the Job Service retry interval

See content here: https://deploy-preview-134--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/cloud/operator/upgrade-serverless-operator/upgrade_1_37_0_to_1_37_1#config_jobs_service_retry_interval

image
  1. And finally, as part of the Finalizing the upgrade, the last step must be:

Restore the Jobs Service retry interval

See content here:

https://deploy-preview-134--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/cloud/operator/upgrade-serverless-operator/upgrade_1_37_0_to_1_37_1#restore_jobs_service_retry_interval

image

Would you mind prioritize this changes so we can merge this PR?

@kaldesai
Copy link
Copy Markdown
Author

@wmedvede I have incorporated your suggetsions. Thank you!

@wmedvede
Copy link
Copy Markdown

@wmedvede I have incorporated your suggetsions. Thank you!

Looks great!
Really much appreciate your hard work and making time to incorporate this last moment adding.
Thank you!

@kaldesai kaldesai force-pushed the SRVLOGIC-781-OSL-1.37.0-to-1.37.1 branch from e63c8c7 to 3676351 Compare March 27, 2026 13:15
@wmedvede
Copy link
Copy Markdown

Hi @kaldesai do we need more people reviewing this one, or it can be merged?

@kaldesai
Copy link
Copy Markdown
Author

Hi @kaldesai do we need more people reviewing this one, or it can be merged?

@wmedvede I have got the ack from you and Dominik, that's sufficient. It is currently in the merge-review process

@kaldesai kaldesai force-pushed the SRVLOGIC-781-OSL-1.37.0-to-1.37.1 branch from 2f1c9c5 to d41dc59 Compare March 30, 2026 09:19
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2026

@kaldesai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit ea96696 into openshift:serverless-docs-main Mar 30, 2026
2 checks passed
@briandooley
Copy link
Copy Markdown
Contributor

/cherrypick serverless-docs-1.37

@briandooley
Copy link
Copy Markdown
Contributor

/cherrypick serverless-docs-1.38

@openshift-cherrypick-robot
Copy link
Copy Markdown

@briandooley: new pull request created: #109188

Details

In response to this:

/cherrypick serverless-docs-1.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@briandooley: new pull request created: #109189

Details

In response to this:

/cherrypick serverless-docs-1.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants